whscullin / apple2js

An Apple II emulator originally written in Javascript, now being converted to TypeScript
http://www.scullinsteel.com/apple2/
MIT License
438 stars 57 forks source link

Simplify op table #194

Closed whscullin closed 1 year ago

whscullin commented 1 year ago

Typescript was never quite happy with how it was being done before, this seems slightly more performant anyway.

iflan commented 1 year ago

Hey Will,

Did you run the benchmarks on this? I remember that I made a benchmark way back to test different versions of the op dispatching. I can try to resurrect that if you want.

Ian

whscullin commented 1 year ago

I am curious to do more formal analysis, so I may do that, but the wall clock comparison running the 6502 test suite was striking enough that this seemed to be an easy win.