search

widgetti / ipyvolume

3d plotting for Python in the Jupyter notebook based on IPython widgets using WebGL
MIT License
1.95k stars 236 forks source link

Support ipywidgets 8 #411

Closed jtpio closed 1 year ago

jtpio commented 2 years ago

Start testing support for ipywidgets 8.

Similar to https://github.com/matplotlib/ipympl/pull/461

maartenbreddels commented 2 years ago

Thanks!

Visual differences I'm ok with, do you know if the lab2 build can be fixed?

jtpio commented 2 years ago

do you know if the lab2 build can be fixed?

Wondering if this might be related to https://github.com/jupyterlab/jupyterlab/issues/11248 according to the log in https://github.com/widgetti/ipyvolume/runs/7516085636?check_suite_focus=true.

jtpio commented 2 years ago

Opened https://github.com/widgetti/ipyvolume/pull/412 to start troubleshooting this.

maartenbreddels commented 2 years ago

Ah, I think we need to manually push the visual changes right? Is there a bot that can do that for us?

jtpio commented 2 years ago

I opened https://github.com/widgetti/ipyvolume/issues/413 since this does not seem related to this change.

jtpio commented 2 years ago

Bringing this PR out of draft since ipywidgets 8 was released yesterday.

maartenbreddels commented 1 year ago

Failure needs network related. Thanks Jeremy!