search

wied03 / cookbook-gpg

GPG cookbook for Chef, LWRP focused
2 stars 8 forks source link

fails on keys with multiple ids #1

Closed bkw closed 10 years ago

bkw commented 10 years ago

The parser logic in BswTech::Gpg::GpgParser#parse cannot seem to handle public keys with multiple ids, at least it fails on mine (https://keybase.io/bkw/key.asc). I tried to fix it myself, but I'm not sure whether I understood the approach correctly. Maybe you want to support that case.

cheers, bkw

wied03 commented 10 years ago

Thanks for catching that. I'm a GPG noob. I created a new branch and started working on this.

bkw commented 10 years ago

Cool! My attempts at fixing this broke the examples "parses multiple ring secret keys" and "parses properly with multiple public ring keys there", so I guess they won't help you much ;-)

Out of curiosity: Any reason for the unconventional directory layout? I've never seen this before. I was more used to providers and resources living in their respective sub-directories.

wied03 commented 10 years ago

It allows using the HWRP syntax for creating them as Ruby classes. Since I've developed a lot of Ruby in the past, it flows more naturally to me than using the LWRP setup.

bkw commented 10 years ago

i see, thanks.

wied03 commented 10 years ago

Fixed in 0.2.2

bkw commented 10 years ago

Works like a charm! Thanks for the lightspeed response!