search

wieringen / tinyscrollbar

A lightweight cross browser javascript scrollbar.
http://baijs.com/tinyscrollbar
Other
398 stars 203 forks source link

wheelLock: false not working on mobile #45

Open NinjaKC opened 9 years ago

NinjaKC commented 9 years ago

Heya guys, so far I love this plugin, lightweight and gets the job done, and gives you a little extend-ability. (only complaint is css needs a little work out-the-box)

One thing I notice though, is the wheelLock: false works on a desktop, but when in Android Chrome, it does not work (this is where I feel it is needed the most, as at times the scroll box may take up the full window, and you should have some way to scroll out of that div and back into the page on mobile).

Anyway, awesome code guys keep it up, it would be awesome if I can get a fix on this without having to dive into the code, but may end up doing it anyway and reporting back here. Please let me know if anyone has already fixed this, it would be of great help on a large project I am working on.

Thanks.

wieringen commented 9 years ago

Thanks for the info I will try and see if I can duplicate your findings.

NinjaKC commented 9 years ago

Awesome, I have uber busy myself, else I would have tried to fix it. If ya come through for me on this, I will stick around and help contribute with tinyscroller where ever I can ;)

Thanks again.

Casey Childers Phone #: 817-247-9109 www.Visual-Optics.com http://www.visual-optics.com/ 2D Grahics, 3D Models, Bone Rigging, Basic Animation (2D / 3D), Web Designer & Developer (HTML, CSS, JS, PHP, MySQL Guru), Content Writer, Site Optimizer, Search Engine Optimizer, Web Analyzer, Project Manager, Hosting, VPS, If you need it done, I will figure out how to get it done.

On Tue, Dec 16, 2014 at 2:37 AM, Maarten Baijs notifications@github.com wrote:

Thanks for the info I will try and see if I can duplicate your findings.

— Reply to this email directly or view it on GitHub https://github.com/wieringen/tinyscrollbar/issues/45#issuecomment-67140563 .

wieringen commented 9 years ago

I added touchLock. Can you check if it works correctly? Its working on my iPhone pretty well.

NinjaKC commented 9 years ago

Maarten,

Thanks!

I will have a chance to check this out tomorrow when I am back onto that project. I will give you an update sometime after I try it.

Thanks Again!

Casey Childers Phone #: 817-247-9109 www.Visual-Optics.com http://www.visual-optics.com/ 2D Grahics, 3D Models, Bone Rigging, Basic Animation (2D / 3D), Web Designer & Developer (HTML, CSS, JS, PHP, MySQL Guru), Content Writer, Site Optimizer, Search Engine Optimizer, Web Analyzer, Project Manager, Hosting, VPS, If you need it done, I will figure out how to get it done.

On Tue, Dec 16, 2014 at 11:40 AM, Maarten Baijs notifications@github.com wrote:

I added touchLock. Can you check if it works correctly? Its working on my iPhone pretty well.

— Reply to this email directly or view it on GitHub https://github.com/wieringen/tinyscrollbar/issues/45#issuecomment-67218576 .

wieringen commented 9 years ago

Great thanks! :)

NinjaKC commented 9 years ago

I had a chance to test this, it seems to half work on my end. There seems to be a bug when I 'touch' the div that has the scroll, and drag my finger without picking it up, will scroll the main window and leave the div with scroll in limbo.

On the other hand, if I touch outside of the div, and drag down the scroll for the main mobile works, when I then touch inside the div, and then touch [a second time] and drag inside the div, it works.

My assumption of how this would work, is when a touch event happens (or touch and drag) happens inside a div with tinyscroller turned on (and touchLock false), then the div that is touched (or touched and dragged) will scroll, if the scroll bar is at the end of the div and you keep trying to scroll down, the main window scroll bar would take over and allow scrolling further down.

In the cases where I center the div on the screen, then release, and touch and drag, I can get it to work as expected (as described above).

Another error shows this same issue, where one would center the div and successfully drag to the end of the div with touch and drag, and continuing to drag down the window scrolls as expected, but if I dont release my finger and drag back up, one would expect the scroll window the stop at the div and sroll the div into view / backwards to the top until the scroll reaches the other end, and the window scroll takes over again.

I appreciate your approach this far, and realize what I am asking for may be a little complicated. I still have a couple months out on this project, so fixing this bug will come in time on my end, if you don't get to it before me.

Thanks again dude for the feature / bug fix!

wieringen commented 9 years ago

Thanks for testing. Not yet sure on how i can fix this. I first have to reproduce it.