search

wighawag / clones-with-immutable-args

BSD 3-Clause "New" or "Revised" License
229 stars 44 forks source link

create2 option #11

Closed z0r0z closed 10 months ago

z0r0z commented 2 years ago

add create2 optionality w/ salt

BlinkyStitt commented 2 years ago

I don't think the is_zero check on salt is the right way to do this. I currently use create2 with empty salts for almost all of my deploys. I do this because I care about easily recreating the same address and not because I want a vanity address. I could change all my code to use a salt of "1" or something as default, but I think two separate functions would be better

strollinghome commented 2 years ago

@wighawag @ZeframLou any chance of getting this merged? Interested in using this and deterministic address would-be killer.

Also, I've been talking to people at Etherscan and they added minor support for detecting these types of clones already. Ideally, we'd get something similar to how EIP-1167 gets code verified automatically for all clones.

wighawag commented 10 months ago

Thanks @z0r0z for the PR and sorry for not looking at it all this time. A new Pr that implement create2 has been merged : https://github.com/wighawag/clones-with-immutable-args/pull/19