The plugin does not obey --no-progress - Githubissues

wikimedia / composer-merge-plugin

Merge one or more additional composer.json files at Composer runtime

MIT License

934 stars 159 forks source link

The plugin does not obey --no-progress #167

Open addshore opened 6 years ago

addshore commented 6 years ago

Step 12/21 : RUN cd /tmp/mediawiki && composer install --no-dev --no-progress --optimize-autoloader
---> Running in 5cb50f68976d
[91m> ComposerHookHandler::onPreUpdate[0m[91m
[0m[91mLoading composer repositories with package information[0m[91m
[0m[91mUpdating dependencies[0m[91m
[0m[91mPackage operations: 32 installs, 0 updates, 0 removals[0m[91m
[0m[91m - Installing wikimedia/composer-merge-plugin (v1.4.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing cssjanus/cssjanus (v1.2.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing liuggio/statsd-php-client (v1.0.18): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing oojs/oojs-ui (v0.26.4): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing oyejorge/less.php (v1.7.0.14): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/pear_exception (v1.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/console_getopt (v1.4.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/pear-core-minimal (v1.10.3): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/mail (v1.4.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/mail_mime (1.10.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing pear/mail_mime-decode (1.5.5.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/assert (v0.2.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/base-convert (v1.0.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/cdb (1.4.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/cldr-plural-rule-parser (v1.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/html-formatter (1.0.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/ip-set (1.2.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/object-factory (1.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing psr/log (1.0.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/at-ease (v1.2.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/php-session-serializer (v1.0.6): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/purtle (v1.0.7): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/relpath (2.1.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/utfnormal (v2.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/remex-html (1.0.3): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/running-stat (v1.2.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/scoped-callback (v1.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/timestamp (v1.0.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/wait-condition-loop (v1.0.1): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing wikimedia/wrappedstring (v2.3.0): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing zordius/lightncandy (v0.23): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91m - Installing composer/semver (1.4.2): [0m[91mDownloading[0m[91m (100%)[0m[91m
[0m[91mWriting lock file[0m[91m
[0m[91mGenerating optimized autoload files[0m[91m
[0m[91m> ComposerHookHandler::onPreUpdate[0m[91m
[0m[91mLoading composer repositories with package information[0m[91m
[0m[91mUpdating dependencies[0m[91m
[0m[91mPackage operations: 22 installs, 0 updates, 0 removals[0m[91m
[0m[91m - Installing composer/installers (v1.5.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/data-types (1.0.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/javascript (0.8.4): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/value-view (0.20.1): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/javascript-api (2.2.2): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/data-model-javascript (3.1.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/serialization-javascript (2.1.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing sendgrid/php-http-client (3.9.6): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing sendgrid/sendgrid (6.2.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (50%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/interfaces (0.2.5): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/data-values (1.1.1): [0m[91mDownloading (connecting...)[0m[91mDownloading (0%) Downloading (50%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/common (0.4.1): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/number (0.9.1): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/geo (2.1.1): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (25%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing data-values/time (0.8.6): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing serialization/serialization (4.0.0): [0m[91mDownloading (connecting...)[0m[91mDownloading (0%) Downloading (20%)[0m[91mDownloading (75%)Downloading (100%)
[0m[91m - Installing data-values/serialization (1.2.2): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/data-model (7.5.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (15%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/data-model-serialization (2.7.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/internal-serialization (2.7.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (80%)[0m[91m[0m[91mDownloading (85%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing diff/diff (2.3.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (10%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (55%)[0m[91m[0m[91mDownloading (65%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91m - Installing wikibase/data-model-services (3.10.0): [0m[91mDownloading (connecting...)[0m[91m[0m[91mDownloading (0%)[0m[91m [0m[91m[0m[91m[0m[91mDownloading (5%)[0m[91m[0m[91mDownloading (20%)[0m[91m[0m[91mDownloading (30%)[0m[91m[0m[91mDownloading (35%)[0m[91m[0m[91mDownloading (40%)[0m[91m[0m[91mDownloading (45%)[0m[91m[0m[91mDownloading (60%)[0m[91m[0m[91mDownloading (70%)[0m[91m[0m[91mDownloading (75%)[0m[91m[0m[91mDownloading (90%)[0m[91m[0m[91mDownloading (95%)[0m[91m[0m[91mDownloading (100%)[0m[91m
[0m[91mWriting lock file[0m[91m
[0m[91mGenerating optimized autoload files[0m[91m
[0m[91m> ComposerVendorHtaccessCreator::onEvent[0m[91m
[0m[91m> ComposerVendorHtaccessCreator::onEvent[0m[91m

bd808 commented 6 years ago

This is probably caused by the flag not being propagated to the new installer created by the post-install/post-update hook at https://github.com/wikimedia/composer-merge-plugin/blob/master/src/MergePlugin.php#L354

To fix this we would need to find out how to know if the flag has been enabled in the CLI args and then use it to set setOutputProgress(bool) on the download manager object attached to the Composer object we make at https://github.com/wikimedia/composer-merge-plugin/blob/master/src/MergePlugin.php#L358. Unfortunately I don't see any getters that pair with the setOutputProgress call that would let us query the status of this flag inside the run.