wikimedia / eslint-config-wikimedia

JavaScript style guide for Wikimedia.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript
MIT License
29 stars 20 forks source link

Rename shared configs by grouping in folders #527

Closed edg2s closed 1 year ago

edg2s commented 1 year ago

e.g.

Fixes #525

edg2s commented 1 year ago

This is obviously a large breaking change, so we should be sure this is a sensible approach before merging.

jdforrester commented 1 year ago

Can we leave the old names as redirects ('client-es5': require('client/es5') etc.)?

edg2s commented 1 year ago

Can we leave the old names as redirects ('client-es5': require('client/es5') etc.)?

All the old names are kept as aliases for now: https://github.com/wikimedia/eslint-config-wikimedia/pull/527/files#diff-4e1706d3d1da0ad393b3151e9020e0d075c13b930439acc3c6d12ece63ad7da7

jdforrester commented 1 year ago

Leaving for review by others before merging, as Ed says.

jdforrester commented 1 year ago

Do we want to land this and make a new release?

edg2s commented 1 year ago

Do we want to land this and make a new release?

Happy to land it.