wikimedia / eslint-config-wikimedia

JavaScript style guide for Wikimedia.
https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript
MIT License
29 stars 20 forks source link

Disable noisy security lints in client code #574

Closed edg2s closed 6 months ago

edg2s commented 6 months ago

Most of our unresolved warnings and inline disables come from security warnings around regular expressions. AFAICT this represent a possible sources of very slow code, but not big security concerns as they may do in server side code.

edg2s commented 6 months ago

These rules produced dozens of warnings in VE, for example.

cc @sbassett29 @MatmaRex

sbassett29 commented 6 months ago

Fine with me to disable if they're proving to be more of a hindrance than helpful. Most true ReDoSes are going to be fairly difficult to exploit within much of our JS code.