search

wildfly-extras / prospero

Prospero is a tool combining Galleon feature packs and wildfly-channels to provision and update Wildfly server.
Apache License 2.0
9 stars 24 forks source link

[#726] Allow multiple manifests in the install command #735

Closed spyrkob closed 4 months ago

spyrkob commented 4 months ago

Closes #726

spyrkob commented 4 months ago

@TomasHofman FYI

TomasHofman commented 4 months ago

Looks good! Is there any handling necessary in the channel add command, as you pointed out in the issue? Throwing error if there is more than one manifest defined..?

spyrkob commented 4 months ago

channel add operation should already only accept a single manifest (defined through the @CommandLine.Option annotations), that should not be affected by this changes, unless I missed something :)

TomasHofman commented 4 months ago

I see, it doesn't inherit from the AbstractInstallCommand. Sounds good :).

spyrkob commented 4 months ago

Thanks for the review @TomasHofman :)