search

will-henney / bowshock-shape

Calculate shape of wind-wind bowshocks
1 stars 0 forks source link

Problem with fitting ellipses in the y(x) form #18

Closed will-henney closed 7 years ago

will-henney commented 11 years ago

The ellipse equation y(x) is only valid for a limited range of x.

However, observational points may lie outside this range, which causes problems for the fits.

One solution would be to use a polar form for the ellipse: r(theta), measured from some internal point (center? focus?). However, this won't be so good for the hyperbolae, since they only have a solution for theta > theta_inf

will-henney commented 10 years ago

I have now (commit debd079) included the other branch for ellipses and circles in the conic section plotting functions (conic_utils.py), but I haven't tried using it in the fits yet.

will-henney commented 7 years ago

This doesn't seem to be an important problem any more