willaguiar / ASC_and_heat_transport

Github repository for Analysis of ASC speed and cross slope heat transport on Panan simulation
0 stars 0 forks source link

Figure discussion for paper #26

Open adele-morrison opened 5 months ago

adele-morrison commented 5 months ago

Here's an issue we can discuss figure formatting etc for the paper. There is a list of the figures here.

ongqingyee commented 3 months ago

I have a script for Figure 2 on my branch, below are two examples with the spaces for scatter/pdfs. Both figures below are the same except for row two - I have one with binned correlations and one with domain averages. We can change this after we finalise the binning problem. The thick line is for significant depths with p < 0.05.

Using domain averaged correlations - binned 5 deg in spatial picture. -- threshold of p < 0.05 image

Using binned layerwise correlations - 5 deg -- threshold of p = 0.05 download

adele-morrison commented 2 weeks ago

Recording this here, because I will likely forget otherwise. I think there is a bug in the current Figure 2 script that correlates the heat transport with the depth-averaged ASC: U_along_depthav = masked_u_along.mean('lon').mean('depth').regimes_mask This averages u_along over depth with an even weighting of all z-levels, but we should use thickness-weighted averaging, so the lower thicker layers are weighted more than the upper thinner layers.

ongqingyee commented 1 week ago

I've updated the weighting and the code with the pdfs. Currently the pdf shows a scatter of full depth averaged ualong (top rightmost) and depth averaged ualong for 433-1333m only (middle rightmost) so that's why the pdfs look the same (scatter of CSHT and Ualong in longitude bins and time). Could filter for only averaging over significant depths in pdf plot but won't pursue this more for now since we are moving to density but recording as the current state of Fig 2.

U_along_depthav = u_along_layerwise_binned.weighted(u_along_layerwise_binned.depth).mean('depth')

download