search

willdurand / Hateoas

A PHP library to support implementing representations for HATEOAS REST web services.
https://williamdurand.fr/Hateoas/
Other
1.04k stars 118 forks source link

Switch to frankenstein #71

Closed adrienbrault closed 10 years ago

adrienbrault commented 10 years ago

Simply because I find atoum's output unreadable when there are errors, the "test class has the same name as the tested class" is bullshit, and prophecy feels way better than atoum's mocks.

https://github.com/hautelook/frankenstein

willdurand commented 10 years ago

Whaaat?

Frankly, if I didn't know why I disliked Atoum, now I know. I waste my time writing tests with Atoum. So either we switch to PHPUnit, or we deal with Atoum because... it is too late. Also, "mocks" should be dead simple, so no need to use yet another third-party lib to write mocks, keep it simple...

adrienbrault commented 10 years ago

Too late ?

adrienbrault commented 10 years ago

Switching to frankenstein just means changing the base test class, and updating mocks.

willdurand commented 10 years ago

If we run the test suite using PHPUnit, we should rename each test class, and method to fit PHPUnit naming conventions.

adrienbrault commented 10 years ago

willdurand commented 10 years ago

:-)

But then, why do we need Frankenstein?

adrienbrault commented 10 years ago

Frankenstein let you run your tests with PHPUnit, using atoum's asserters and prophecy mocks; which is IMHO the best of each world.

willdurand commented 10 years ago

Well... Do you really want to waste your time rewriting/renaming tests/classes?