willfarrell / alfred-pkgman-workflow

Package Repo Search
MIT License
699 stars 57 forks source link

XDebug Trigger should probably be a checkbox #174

Closed vitorgalvao closed 1 year ago

vitorgalvao commented 1 year ago

What are the valid values for XDEBUG_TRIGGER? If they’re 0 and 1, that’s what the checkbox returns and it makes more sense than a Text Field.

But I don’t see that option documented, it seems to only be useful for yourself during development, right? That being the case, that option can remain as a Workflow Environment Variable because it’s not something users will ever want to change (i.e. it’s not user-facing configuration).

jeffbyrnes commented 1 year ago

Yep, it’s a development-only option, and it’s been set to 1 for a long time.

@willfarrell maybe we remove it entirely?

willfarrell commented 1 year ago

Go for it.