[Bug]: HA 2024.7.x Detected code that calls async_forward_entry_setup

[wills106]

Describe the bug

Detected code that calls async_forward_entry_setup for integration solax_modbus with title: SolaX and entry_id: xyz123, during setup without awaiting async_forward_entry_setup, which can cause the setup lock to be released before the setup is done. This will stop working in Home Assistant 2025.1. Please report this issue.

Integration Version

2024.07.0b1

Homeassistant core version

2024.7.0b10

Inverter brand

SolaX

Plugin used

plugin_solax.py

Serial prefix

H1E5

Inverter firmware versions

ARM 3.28, DSP 3.32

Connection Method

Gen3 Ethernet

Dongle firmware

N/A

Detailed Error Log

2024-07-03 09:43:38.436 WARNING (MainThread) [homeassistant.helpers.frame] Detected that custom integration 'solax_modbus' calls async_forward_entry_setup for integration, solax_modbus with title: SolaX and entry_id: xyz123, which is deprecated and will stop working in Home Assistant 2025.6, await async_forward_entry_setups instead at custom_components/solax_modbus/__init__.py, line 339: self._hass.async_create_task(, please create a bug report at https://github.com/wills106/homsassistant-solax-modbus/issues

Additional context

No response

[wills106]

There is no need for additional reports of this, or for people to also confirm they get this. Everyone on HA 2024.7 will get this. It's the same with #920 on HA 2024.6, everyone will get the error until it's fixed.

It's just a single warning at the start of HA per Inverter configured.

[wills106]

Just released 2024.07.0b2

[wills106]

Reopened as not fully resolved.

[litinoveweedle]

It's the same with #920 on HA 2024.6, everyone will get the error until it's fixed.

Hi, not it is not the same, this one is a new warning, but for similar topic. I can prepare fix for this one as well.

[wills106]

Hi, not it is not the same, this one is a new warning

I know it's different, I just meant everyone will get this error like everyone got the last error. So no need for people to keep reporting it.

[PatrikTrestik]

It's the same with #920 on HA 2024.6, everyone will get the error until it's fixed.

Hi, not it is not the same, this one is a new warning, but for similar topic. I can prepare fix for this one as well.

@litinoveweedle are you working on it? I can do it, but I don't want to duplicate work.

[litinoveweedle]

@PatrikTrestik sorry not yet on the task, busy this weekend with unrelated stuff, Johny Goose day you know... 🤣 I got time only for quick try to put await for the reported coroutine, but it was not enough to fix it. So if you have solution please feel free to PR.

[PatrikTrestik]

@PatrikTrestik sorry not yet on the task, busy this weekend with unrelated stuff, Johny Goose day you know... 🤣 I got time only for quick try to put await for the reported coroutine, but it was not enough to fix it. So if you have solution please feel free to PR.

Will work on it tomorrow. I'll post PR in case I have success :)

[PatrikTrestik]

@PatrikTrestik sorry not yet on the task, busy this weekend with unrelated stuff, Johny Goose day you know... 🤣 I got time only for quick try to put await for the reported coroutine, but it was not enough to fix it. So if you have solution please feel free to PR.

Will work on it tomorrow. I'll post PR in case I have success :)

@wills106 please consider allowing contributors in this reporsitory. We can than asign ourselves to tasks to indicate workload. It will be still you who accepts PRs, but our coordination will be easier.