wimpysworld / deb-get

apt-get for .debs published via GitHub or direct download 📦
MIT License
1.35k stars 123 forks source link

Remove unused dependency: software-properties-common #1216

Open kindrowboat opened 6 days ago

kindrowboat commented 6 days ago

Fixes #1215

A cursory glace at the code shows that we weren't using software-properties-common, at least not apt-add-repository. I've confirmed that this package builds and installs on Debian Trixie.

Build and manual test:

kindrobot@framian ~/w/deb-get (main)> dpkg-buildpackage --build=binary --no-check-builddeps --compression=gzip --no-sign
dpkg-buildpackage: info: source package deb-get
dpkg-buildpackage: info: source version 0.3.9-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Martin Wimpress <code@wimpress.io>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source --compression=gzip --before-build .
 debian/rules clean
dh clean
   dh_clean
 debian/rules binary
dh binary
   dh_update_autotools_config
   dh_autoreconf
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_auto_install --destdir=debian/deb-get/
   dh_install
   dh_installdocs
   dh_installchangelogs
   dh_installman
   dh_perl
   dh_link
   dh_strip_nondeterminism
   dh_compress
   dh_fixperms
   dh_missing
   dh_installdeb
   dh_gencontrol
   dh_md5sums
   debian/rules override_dh_builddeb
make[1]: Entering directory '/home/kindrobot/wrk/deb-get'
dh_builddeb -- -Zgzip
dpkg-deb: building package 'deb-get' in '../deb-get_0.3.9-1_all.deb'.
make[1]: Leaving directory '/home/kindrobot/wrk/deb-get'
 dpkg-genbuildinfo --build=binary -O../deb-get_0.3.9-1_amd64.buildinfo
 dpkg-genchanges --build=binary -O../deb-get_0.3.9-1_amd64.changes
dpkg-genchanges: info: binary-only upload (no source code included)
 dpkg-source --compression=gzip --after-build .
dpkg-buildpackage: info: binary-only upload (no source included)
kindrobot@framian ~/w/deb-get (main)> cd ..
kindrobot@framian ~/wrk> ls
deb-get/                 deb-get_0.3.9-1_amd64.buildinfo
deb-get_0.3.9-1_all.deb  deb-get_0.3.9-1_amd64.changes
kindrobot@framian ~/wrk> sudo apt install ./deb-get_0.3.9-1_all.deb
Note, selecting 'deb-get' instead of './deb-get_0.3.9-1_all.deb'
Installing:
  deb-get

Summary:
  Upgrading: 0, Installing: 1, Removing: 0, Not Upgrading: 67
  Download size: 0 B / 23.7 kB
  Space needed: 89.1 kB / 402 GB available

Get:1 /home/kindrobot/wrk/deb-get_0.3.9-1_all.deb deb-get all 0.3.9-1 [23.7 kB]
Selecting previously unselected package deb-get.
(Reading database ... 204031 files and directories currently installed.)
Preparing to unpack .../wrk/deb-get_0.3.9-1_all.deb ...
Unpacking deb-get (0.3.9-1) ...
Setting up deb-get (0.3.9-1) ...
  [+] Updating /etc/deb-get/01-main
 #=#=- #   #
  [+] Updating cache of supported apps in the background
Processing triggers for man-db (2.13.0-1) ...
Notice: Download is performed unsandboxed as root as file '/home/kindrobot/wrk/deb-get_0.3.9-1_all.deb' couldn't be accessed by user '_apt'. - pkgAcquire::Run (13: Permission denied)
kindrobot@framian ~/wrk> deb-get update
  [+] Updating /etc/deb-get/01-main
 #=#=- #   #
  [+] Updating cache of supported apps in the background
Hit:1 http://security.debian.org/debian-security trixie-security InRelease
Get:2 http://ftp.ca.debian.org/debian trixie InRelease [172 kB]
Get:3 http://ftp.ca.debian.org/debian trixie-updates InRelease [49.6 kB]
Get:4 http://ftp.ca.debian.org/debian trixie/main Sources.diff/Index [27.9 kB]
Get:5 http://ftp.ca.debian.org/debian trixie/non-free-firmware Sources.diff/Index [27.8 kB]
Get:6 http://ftp.ca.debian.org/debian trixie/main amd64 Packages.diff/Index [27.9 kB]
Get:7 http://ftp.ca.debian.org/debian trixie/main Translation-en.diff/Index [27.9 kB]
Get:8 http://ftp.ca.debian.org/debian trixie/non-free-firmware amd64 Packages.diff/Index [27.8 kB]
Get:9 http://ftp.ca.debian.org/debian trixie/main Sources 2024-11-22-0207.16.pdiff [27.7 kB]
Get:10 http://ftp.ca.debian.org/debian trixie/main Sources 2024-11-22-0804.38.pdiff [1,507 B]
Get:11 http://ftp.ca.debian.org/debian trixie/main Sources 2024-11-22-1404.47.pdiff [62 B]
Get:12 http://ftp.ca.debian.org/debian trixie/non-free-firmware Sources 2024-11-22-0207.16.pdiff [311 B]
Get:13 http://ftp.ca.debian.org/debian trixie/main amd64 Packages 2024-11-22-0207.16.pdiff [36.5 kB]
Get:14 http://ftp.ca.debian.org/debian trixie/main amd64 Packages 2024-11-22-0804.38.pdiff [1,142 B]
Get:15 http://ftp.ca.debian.org/debian trixie/main Translation-en 2024-11-22-0207.16.pdiff [5,375 B]
Get:16 http://ftp.ca.debian.org/debian trixie/main Translation-en 2024-11-22-0804.38.pdiff [617 B]
Get:11 http://ftp.ca.debian.org/debian trixie/main Sources 2024-11-22-1404.47.pdiff [62 B]
Get:16 http://ftp.ca.debian.org/debian trixie/main Translation-en 2024-11-22-0804.38.pdiff [617 B]
Get:14 http://ftp.ca.debian.org/debian trixie/main amd64 Packages 2024-11-22-0804.38.pdiff [1,142 B]
Get:12 http://ftp.ca.debian.org/debian trixie/non-free-firmware Sources 2024-11-22-0207.16.pdiff [311 B]
Get:17 http://ftp.ca.debian.org/debian trixie/non-free-firmware amd64 Packages 2024-11-22-0207.16.pdiff [227 B]
Get:17 http://ftp.ca.debian.org/debian trixie/non-free-firmware amd64 Packages 2024-11-22-0207.16.pdiff [227 B]
Get:18 http://ftp.ca.debian.org/debian trixie/main amd64 Components [4,587 kB]
Get:19 http://ftp.ca.debian.org/debian trixie/main Icons (48x48) [3,456 kB]
Get:20 http://ftp.ca.debian.org/debian trixie/main Icons (64x64) [6,973 kB]
Get:21 http://ftp.ca.debian.org/debian trixie/main Icons (128x128) [10.8 MB]
Get:22 http://ftp.ca.debian.org/debian trixie/non-free-firmware amd64 Components [21.0 kB]
Fetched 26.3 MB in 1s (17.6 MB/s)
Reading package lists...
  [+] deb-get (0.3.9-1) has an update pending. 0.4.3-1 is available.
kindrobot@framian ~/wrk> deb-get install vivaldi-stable
--2024-11-22 15:11:38--  https://repo.vivaldi.com/stable/linux_signing_key.pub
Resolving repo.vivaldi.com (repo.vivaldi.com)... 151.101.125.91
Connecting to repo.vivaldi.com (repo.vivaldi.com)|151.101.125.91|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 3175 (3.1K) [application/octet-stream]
Saving to: ‘/usr/share/keyrings/vivaldi-archive-keyring’

/usr/share/keyrings/v 100%[======================>]   3.10K  --.-KB/s    in 0s

2024-11-22 15:11:38 (7.78 MB/s) - ‘/usr/share/keyrings/vivaldi-archive-keyring’ saved [3175/3175]

  [+] Updating: /etc/apt/sources.list.d/vivaldi.list
Ign:1 https://repo.vivaldi.com/stable/deb stable InRelease
Get:2 https://repo.vivaldi.com/stable/deb stable Release [3,840 B]
Get:3 https://repo.vivaldi.com/stable/deb stable Release.gpg [833 B]
Get:4 https://repo.vivaldi.com/stable/deb stable/main amd64 Packages [1,956 B]
Fetched 6,629 B in 1s (11.9 kB/s)
Reading package lists... Done
Selecting previously unselected package vivaldi-stable.
(Reading database ... 204037 files and directories currently installed.)
Preparing to unpack .../vivaldi-stable_7.0.3495.18-1_amd64.deb ...
Unpacking vivaldi-stable (7.0.3495.18-1) ...
Setting up vivaldi-stable (7.0.3495.18-1) ...
update-alternatives: using /usr/bin/vivaldi-stable to provide /usr/bin/x-www-browser (x-www-browser) in auto mode
update-alternatives: using /usr/bin/vivaldi-stable to provide /usr/bin/gnome-www-browser (gnome-www-browser) in auto mode
update-alternatives: using /usr/bin/vivaldi-stable to provide /usr/bin/vivaldi (vivaldi) in auto mode
Processing triggers for desktop-file-utils (0.27-2) ...
Processing triggers for mailcap (3.74) ...