wimpysworld / desktopify

Convert Ubuntu Server for Raspberry Pi into a Desktop
https://www.youtube.com/watch?v=umtZuUJOU38
MIT License
520 stars 89 forks source link

Fix ShellCheck error on Desktop Packages Check (Fixes #68) #69

Closed teward closed 2 years ago

teward commented 3 years ago

The shellcheck complaint wants us to grep -q in line, however it also is complaining about the -n checks being done when it was an in line command call.

This change pulls the apt | grep into its own variable, then checks if that variable and its output is null/empty. If it is, then it's not installed, otherwise throw the warning.

This should fix the CI failures as seen in other pull reqs on this line.