search

wincohi / bookmark-notes

a firefox webextension to bring back pre-62 bookmark annotations
Mozilla Public License 2.0
23 stars 4 forks source link

Export Bookmark Notes #26

Open pixelmode opened 5 years ago

pixelmode commented 5 years ago

Feature Request

After all the cool changes (better UI, search bar, imports that work), I thought I'd throw another thing on the pile.

Need a way backup the notes in the future. Any changes in notes mode are not reflected on a bookmark export (only the original notes are exported). Would this need to be a separate backup and import? Would make them more portable and less likely to be lost if backed up.

wincohi commented 5 years ago

I could see two ways of handling this.

Firstly, given an exported bookmarks file, we append the notes to the file and re-download it as something like bookmarks_notes.html. This would keep everything in the same place and allow importing of both bookmarks and notes across machines and installations.

Alternatively, we could export just the notes themselves in their own file. This might require a change in the way imports are currently parsed (though it also might not), but it would mean transporting just your notes would be doable with a smaller file size. If file size is a concern.

pixelmode commented 5 years ago

I see both being an option, maybe.

Full file: Syncing up with another machine via the file exports is one way I do it when the cloud is not an option or disallowed. I have not moved/copied this to another machine yet, as I've already altered and added bookmarks. Kinda forgot about that until I tested and submitted this issue. So keeping the info in one place is a good option.

The leaner version sounds good too, and I can see some advantages in various situations.

Size not a big deal for me. But the import functions might not like it once I get to 20,000 bookmarks with very long favicon data. Adding three of the longer favicons together is larger than all my notes combined. Kinda wish those could be left out of the bookmark export (by option) but the rest remain, which would reduce the size a lot. Note: I am assuming the favicon is or can be updated in the bookmarks if a site is visited - I've never really payed attention to that aspect.

wincohi commented 5 years ago

While I'm probably going to focus the rest of 1.2 on the various performance issues I've got piling up, I'd like to have exporting out with 1.3, so I'll go ahead and mark it as such.

Rather than appending the notes to an existing export, I'll probably just have the add-on generate its own file, but with a similar HTML structure so we won't have to change up the parsing code too much.

ChattaChick commented 5 years ago

This is a really good add-on, emmyemi, and just needs a few tweaks to become great. I've already recommended Bookmark Notes to others who miss the Descriptions field, but exporting is vital, as we learned when Mozilla took our notes away. Looks like maybe you're taking a break from it, but please come back sometime to finish some of the improvements you've planned.