search

windkh / valloxserial

Library for serial communication (RS485) with a vallox device. Arduino mysensors example included.
8 stars 4 forks source link

Update license #2

Open poiua opened 2 years ago

poiua commented 2 years ago

Amazing work with how complete your library is!

Could you please consider updating license to LGPLv3/MIT/similar which would allow using your library without making Arduino code 'tainted'?

According to https://choosealicense.com/licenses/ GPLv3 is "conditioned on making available complete source code of licensed works and modifications, which include larger works using a licensed work, under the same license."

Some examples of licenses are available in https://choosealicense.com/licenses/

I would like to use this library in my private Arduino project.

windkh commented 2 years ago

@poiua Thanks for pointing this out. I will add it of course.

I am a little bit curious.... what project is it or what type of device do you control. I thought that vallox certainly introduced some new interface during the last years and that probably this one is outdated.

BTW: ... I think there is still a minor bug in the lib that I need to fix someday. It is about the service reminder flag. I will create an issue for that.

poiua commented 2 years ago

Thank you!

I am trying to automate Vallox Digit SE. Good to hear about the new interface, however my device still seems to use your interface.

Currently I am using this project https://github.com/kotope/valloxesp with ESP8266, but it is missing some features that your library has.

windkh commented 2 years ago

If your project is not a commercial one then feel free to include the code from here… @poiua isn‘t it?