Wing swaps structs with the same name, even if they're private scoped

[skyrpex]

I tried this:

// main.w
bring cloud;
bring "./resource-a.w" as resource_a;
bring "./resource-b.w" as resource_b;

let resourceA = new resource_a.ResourceA();
let resourceB = new resource_b.ResourceB();

new cloud.Function(inflight () => {
    resourceA.push(
        a: "Hello, a!",
    );

    resourceB.push(
        b: "Hello, b!",
    );
});

// resource-a.w
bring cloud;

struct QueueMessage {
    a: str;
}

pub class ResourceA {
    queue: cloud.Queue;

    new() {
        this.queue = new cloud.Queue();
        this.queue.setConsumer(inflight (message) => {
            let event = QueueMessage.parseJson(message);
            log(unsafeCast(event));
        });
    }

    pub inflight push(event: QueueMessage) {
        this.queue.push(Json.stringify(event));
    }
}

// resource-b.w
bring cloud;

struct QueueMessage {
    b: str;
}

pub class ResourceB {
    queue: cloud.Queue;

    new() {
        this.queue = new cloud.Queue();
        this.queue.setConsumer(inflight (message) => {
            let event = QueueMessage.parseJson(message);
            log(unsafeCast(event));
        });
    }

    pub inflight push(event: QueueMessage) {
        this.queue.push(Json.stringify(event));
    }
}

This happened:

• The language server mistakes the QueueMessage from resource-b.w

  "b" is not a field of "QueueMessage"
  Missing required field "a" from "QueueMessage"

• Wing compiles the ResourceB with ResourceA's QueueMessage! This is a quite serious bug since it can happen silently

I expected this:

Each resource should use their own private scoped QueueMessage structs.

Is there a workaround?

Renaming the structs.

Anything else?

No response

Wing Version

0.59.8

Node.js Version

No response

Platform(s)

No response

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.

[eladb]

@Chriscbr looks like this is related to modules, no?

[meirdev]

I think it's just a typo, you wrote:

let resourceA = new resource_a.ResourceA();
let resourceB = new resource_a.ResourceA();

Should be:

let resourceA = new resource_a.ResourceA();
let resourceB = new resource_b.ResourceB();

[skyrpex]

I think it's just a typo, you wrote:

let resourceA = new resource_a.ResourceA();

let resourceB = new resource_a.ResourceA();

Should be:

let resourceA = new resource_a.ResourceA();

let resourceB = new resource_b.ResourceB();

Thanks, I fixed the typo in the issue.

[monadabot]

Congrats! :rocket: This was released in Wing 0.74.33.