search

winstonjs / node-loggly

A client implementation for Loggly in node.js
http://github.com/winstonjs/node-loggly
Other
233 stars 81 forks source link

Made bulk mode configurable #47

Closed varshneyjayant closed 9 years ago

varshneyjayant commented 9 years ago
  1. Adding 100 logs in array if the isBulk is set to true
  2. Sends the logs after 30 seconds if logs are less than 100
mostlyjason commented 9 years ago

@indexzero possible to get this merged? We are trying to address this issue https://github.com/winstonjs/winston-loggly/issues/6. This should also help a lot with performance.

indexzero commented 9 years ago

Please conform to the style of the existing code base.

varshneyjayant commented 9 years ago

@indexzero thanks for the styling check. We have fixed the 2 soft tab spaces and camel case issues.

indexzero commented 9 years ago

@psquickitjayant still some small errors here. You can test them by running:

npm i -g common-style
common lib/

My apologies for not making this more transparent. I am going to update this repo now to use that as part of the CI/CD process.

indexzero commented 9 years ago

@psquickitjayant if you rebase now and run:

npm run pretest

You will see the errors relating to code style. Would love some help getting this repo fully setup on TravisCI since we need to encrypt the loggly credentials.

@mostlyjason would love some help from Loggly on this :smile_cat:

varshneyjayant commented 9 years ago

closing this pull request. I will send a new one with latest code changes