search

winstonjs / winston-mongodb

A MongoDB transport for winston
https://github.com/winstonjs/winston-mongodb
295 stars 124 forks source link

bump mongodb driver to 5.9.1 #254

Open ahmedissa opened 10 months ago

ahmedissa commented 10 months ago

Hi,

Dependency Changes:

Code Changes:

Any help or guidance are appreciated.

DABH commented 8 months ago

@curledUpSheep any idea why your CI setup did not run on this PR?

DABH commented 8 months ago

At a glance, this looks good to me, but I'll note that due to the changes in required node versions etc., we would need to ship this as a major release (which I'm fine with).

curledUpSheep commented 8 months ago

@DABH CI did not run on this PR because it has conflicts. Apparently this is a GitHub Actions limitation. See also https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request:

Workflows will not run on pull_request activity if the pull request has a merge conflict. The merge conflict must be resolved first. Conversely, workflows with the pull_request_target event will run even if the pull request has a merge conflict. Before using the pull_request_target trigger, you should be aware of the security risks. For more information, see pull_request_target.

Because of the mentioned security risks, I don't think it's a good idea to switch to using pull_request_target.

Based on the documentation, it seems that CI should run on this PR once conflicts are resolved.

ahmedissa commented 7 months ago

@curledUpSheep @DABH

I just fixed the conflict and i hope the changes land soon. Thanks a lot for responding and happy new year!