search

wintercms / web-installer

Web-based installer for Winter CMS
https://wintercms.com/
MIT License
30 stars 4 forks source link

Post-install additions to .htaccess #28

Closed joho1968 closed 2 years ago

joho1968 commented 2 years ago

Just my two cents:

Add a re-write rule to .htaccess in your post-installation code that re-directs /install.html and /install/ to the starting page.

bennothommo commented 2 years ago

Sorry for the delay in responding to this @joho1968.

The installer removes the install.html file and install directory at the end of the installation - see https://github.com/wintercms/web-installer/blob/main/public/install/api/src/Api.php#L667-L676, so a rewrite rule wouldn't be needed. I don't think it would be a good idea to have an arbitrary rule in the .htaccess for this, especially on the (admittedly unlikely) chance that someone actually wants a page path in their site to be /install/, like we do, and they forget to remove it from the .htaccess file.