search

wintercms / wn-translate-plugin

Translate plugin for Winter CMS
MIT License
14 stars 18 forks source link

Cleanup after model is deleted #81

Closed mjauvin closed 6 months ago

mjauvin commented 7 months ago

Fixes #12

mjauvin commented 7 months ago

@lex0r can you test if this resolves the issue?

LukeTowers commented 7 months ago

How does this handle the parent record being soft deleted?

mjauvin commented 7 months ago

It doesn't... I'll apply conditionally in afterModelDelete() then.

mjauvin commented 7 months ago

@LukeTowers that should address the softdelete concern.

LukeTowers commented 7 months ago

Is there a way that we can support deleting the data when a softdeleted record is permanently deleted?

mjauvin commented 7 months ago

Is there a way that we can support deleting the data when a softdeleted record is permanently deleted?

Good point. That should do it.

LukeTowers commented 7 months ago

Just waiting on @lex0r to test and confirm and this should be good to merge.

Thanks @mjauvin, great job!

mjauvin commented 6 months ago

@lex0r it would really be appreciated if you could test this in your environment so we can get this merged.

Thanks!

lex0r commented 6 months ago

Hi @mjauvin Sorry for the delay, it works for me and thanks for the fix!