search

winterhazel / hide-promoted-jobs

Hides promoted job postings on LinkedIn.
MIT License
18 stars 2 forks source link

Firefox extension doesn't work anymore #2

Closed lecanardcolvert closed 1 year ago

lecanardcolvert commented 1 year ago

Hello,

I am using the Firefox extension for some days now and it was working well.

Today it stopped working.

I think this filter doesn't work anymore. https://github.com/winterhazel/hide-promoted-jobs/blob/12efead4e2702918a28333aeba23ed3ade663bc7/js/hide.js#L17

winterhazel commented 1 year ago

Try reinstalling the extension and making sure it is enabled (it should have a badge saying "ON" in the toolbar).

I'm on Firefox too. My LinkedIn hasn't changed at all and the extension still works for me, so I'm not able to look into this on my own.

After reinstalling and making sure the extension is enabled, if it still doesn't work:

  1. Check if there's any errors in the web console
  2. Send me the HTML of any promoted job item (the <li> element, with its children inside) so I can see if something changed
lecanardcolvert commented 1 year ago

I just tried reinstalling and disable/enable but it still doesn't work.

My LinkedIn is in French (Canada) so maybe that's the issue.

Here is the code of a promoted + simplified job offer with skill badge.

<li id="ember199" class="ember-view   jobs-search-results__list-item occludable-update p0 relative scaffold-layout__list-item

              " data-occludable-job-id="3456514830">

              <div>
    <div data-job-id="3456514830" class="job-card-container relative job-card-list
    job-card-container--clickable

    job-card-list--underline-title-on-hover  jobs-search-two-pane__job-card-container--viewport-tracking-4">

  <div id="ember200" class="job-card-list__entity-lockup artdeco-entity-lockup artdeco-entity-lockup--size-4 ember-view">
      <div id="ember201" class="mr1 job-card-list__logo artdeco-entity-lockup__image artdeco-entity-lockup__image--type-square ember-view" type="square">
          <div class="ivm-image-view-model ivm-image-view-model--grid-2   job-card-list__logo-ivm">
    <ul class="ivm-image-view-model__img-list ivm-image-view-model__img-list--size-4">
        <li class="ivm-image-view-model__img-list-item

            ">
          <div class="ivm-view-attr__img-wrapper ivm-view-attr__img-wrapper--use-img-tag display-flex

    ">
<!---->      <img src="https://media.licdn.com/dms/image/C4D0BAQGzopvAWgnqjA/company-logo_100_100/0/1519904454956?e=1683158400&amp;v=beta&amp;t=PryJKLAjtOnKW6wV1T09DpTUSntooS9iB-E6PrBgWbg" loading="lazy" alt="Logo de buybackbooth" id="ember202" class="ivm-view-attr__img--centered ivm-image-view-model__square-img  lazy-image ember-view" width="48" height="48">
</div>
        </li>
        <li class="ivm-image-view-model__img-list-item

            ">
          <div class="ivm-view-attr__img-wrapper ivm-view-attr__img-wrapper--use-img-tag display-flex

    ">
<!---->      <img src="https://media.licdn.com/dms/image/D5635AQGPtIUV620cNA/profile-framedphoto-shrink_100_100/0/1675191736028?e=1675803600&amp;v=beta&amp;t=YMGTQbwEt7KopzXG9v-xfDeSXcQdXHHxSfjpPkjvow8" loading="lazy" alt="Logo de buybackbooth" id="ember203" class="ivm-view-attr__img--centered ivm-image-view-model__circle-img  lazy-image ember-view" width="48" height="48">
</div>
        </li>
    </ul>

      <span class="visually-hidden">Logo de buybackbooth</span>
</div>

</div>

    <div id="ember204" class="flex-grow-1 artdeco-entity-lockup__content ember-view">
      <div id="ember205" class="full-width artdeco-entity-lockup__title ember-view">
            <a data-control-id="F/Ll2jj3Jk+QwWcUlTEODQ==" tabindex="0" href="/jobs/view/3456514830/?eBP=JOB_SEARCH_ORGANIC&amp;refId=hWOdpQ44zZokXOtFq0tOgw%3D%3D&amp;trackingId=F%2FLl2jj3Jk%2BQwWcUlTEODQ%3D%3D&amp;trk=flagship3_search_srp_jobs" id="ember206" class="disabled ember-view job-card-container__link job-card-list__title">
              Back End Developer
            </a>

</div>
      <div id="ember207" class="artdeco-entity-lockup__subtitle ember-view">
          <span class="job-card-container__primary-description ">
              BuyBack Booth
          </span>

      </div>

      <div id="ember208" class="artdeco-entity-lockup__caption ember-view">
            <ul class="job-card-container__metadata-wrapper">
                <li class="job-card-container__metadata-item ">
                  <!---->Montréal, QC (À distance)<!---->
                </li>
<!---->            </ul>
      </div>
<!---->    </div>
    <div class="job-card-container__action-container flex-shrink-zero display-flex
        ">
          <div class="job-card-list__dismiss">
      <button aria-label="Ignorer l’offre d’emploi Back End Developer" id="ember209" class="job-card-container__action artdeco-button artdeco-button--circle artdeco-button--muted artdeco-button--2 artdeco-button--tertiary ember-view" type="button">  <li-icon aria-hidden="true" type="visibility-off" class="artdeco-button__icon"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" data-supported-dps="32x32" fill="currentColor" class="mercado-match" width="32" height="32" focusable="false">
  <path d="M16 11.5a4.64 4.64 0 00-1.95.43l6 6A4.64 4.64 0 0020.5 16a4.42 4.42 0 00-4.5-4.5z"></path>
  <path d="M16 9.5a6.52 6.52 0 015.54 9.92l3.05 3A15.47 15.47 0 0030 16a15 15 0 00-14-9 15.67 15.67 0 00-5.8 1.08l2.38 2.38A6.47 6.47 0 0116 9.5zM3 3.71L8.29 9A15.42 15.42 0 002 16a15 15 0 0014 9 15.45 15.45 0 006.79-1.51l5.5 5.51.71-.71L3.71 3zm8.05 8.05l1.43 1.42a4.49 4.49 0 00-1 2.82A4.42 4.42 0 0016 20.5a4.49 4.49 0 002.82-1l1.42 1.5a6.52 6.52 0 01-9.19-9.19z"></path>
</svg></li-icon>

<span class="artdeco-button__text">

</span></button>
  </div>

<!---->        <!---->

    </div>

</div>

<!---->        <div class="job-card-list__insight">

          <div class="display-flex align-items-center t-black--light t-12">
              <div class="mv1">
                <div class="ivm-image-view-model   ">
    <div class="ivm-view-attr__img-wrapper ivm-view-attr__img-wrapper--use-img-tag display-flex

    ">
    <li-icon type="clipboard-check" class="ivm-view-attr__icon--brand job-card-container__job-insight-image" size="large" role="img" aria-label="Vous avez un badge de compétence préféré"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" data-supported-dps="24x24" fill="currentColor" class="mercado-match" width="24" height="24" focusable="false">
  <path d="M14.73 10H17l-5.5 8L8 14.5l1.34-1.34L11.21 15zM20 3v16a3 3 0 01-3 3H7a3 3 0 01-3-3V3h5.69l.52-1A2 2 0 0112 1a2 2 0 011.76 1l.52 1zm-2 2h-2.6l.6 1.1V7H8v-.9L8.6 5H6v14a1 1 0 001 1h10a1 1 0 001-1z"></path>
</svg></li-icon>
</div>
  </div>
              </div>
            <div class="job-card-container__job-insight-text">
                Vous avez un badge de compétence préféré
            </div>
          </div>

</div>

    <ul class="job-card-list__footer-wrapper job-card-container__footer-wrapper flex-shrink-zero display-flex t-sans t-12 t-black--light t-normal t-roman">
            <li class="job-card-container__footer-item
                job-card-container__footer-item--highlighted t-bold">
              <time datetime="2023-01-31">
                  Il y a 19 minutes
                  <span class="visually-hidden">Au cours des 24&nbsp;dernières heures</span>
              </time>
            </li>
            <li class="job-card-container__apply-method job-card-container__footer-item inline-flex align-items-center">
              <li-icon aria-hidden="true" type="linkedin-bug-color" class="mr1" size="small"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" data-supported-dps="16x16" class="mercado-match" width="16" height="16" focusable="false">
  <path d="M15 2v12a1 1 0 01-1 1H2a1 1 0 01-1-1V2a1 1 0 011-1h12a1 1 0 011 1zM5 6H3v7h2zm.25-2A1.25 1.25 0 104 5.25 1.25 1.25 0 005.25 4zM13 9.29c0-2.2-.73-3.49-2.86-3.49A2.71 2.71 0 007.89 7V6H6v7h2V9.73a1.73 1.73 0 011.52-1.92h.14C10.82 7.8 11 8.94 11 9.73V13h2z" fill="#0a66c2"></path>
</svg></li-icon>

              <!---->Candidature simplifiée<!---->
            </li>
    </ul>
  <span class="visually-hidden" aria-live="polite">

  </span>
</div>

<div id="ember210" class="ember-view"><!----></div>
</div>

    </li>
winterhazel commented 1 year ago

Are you sure the code you sent is from a promoted job? Promoted jobs have a "Sponsorisé" tag on the footer.

lecanardcolvert commented 1 year ago

Yes, that is a promoted job. Yesterday the tag was "Sponsorisé" and today it changed for "Promu(e)".

For me, the first page of the job results shows 21 promoted jobs "Promu(e)" and 4 non-promoted jobs.

winterhazel commented 1 year ago

Oh, you're right, I just realized that it says "Promu(e)" on some pages.

However, the job you sent doesn't have the "Promu(e)" tag, how do you know that it is a promoted job?

lecanardcolvert commented 1 year ago

You're right, my mistake. Here is the code for a promoted job.

<li id="ember253" class="ember-view   jobs-search-results__list-item occludable-update p0 relative scaffold-layout__list-item

              " data-occludable-job-id="3437958949">

              <div>
    <div data-job-id="3437958949" class="job-card-container relative job-card-list
    job-card-container--clickable

    job-card-list--underline-title-on-hover  jobs-search-two-pane__job-card-container--viewport-tracking-6">

  <div id="ember254" class="job-card-list__entity-lockup artdeco-entity-lockup artdeco-entity-lockup--size-4 ember-view">
      <div id="ember255" class="mr1 job-card-list__logo artdeco-entity-lockup__image artdeco-entity-lockup__image--type-square ember-view" type="square">
          <div class="ivm-image-view-model    job-card-list__logo-ivm">
    <div class="ivm-view-attr__img-wrapper ivm-view-attr__img-wrapper--use-img-tag display-flex

    ">
<!---->      <img src="https://media.licdn.com/dms/image/C560BAQHIQOPAZIvzUA/company-logo_100_100/0/1551712110572?e=1683158400&amp;v=beta&amp;t=qlVVe1-kDnkC7qMYpuq_0iTbP31V4Ekntb4p5mibNn0" loading="lazy" alt="Logo de equisoft" id="ember256" class="ivm-view-attr__img--centered EntityPhoto-square-3  lazy-image ember-view" width="56" height="56">
</div>
  </div>

</div>

    <div id="ember257" class="flex-grow-1 artdeco-entity-lockup__content ember-view">
      <div id="ember258" class="full-width artdeco-entity-lockup__title ember-view">
            <a data-control-id="DIjzaqUVGhRM274F52Of+g==" tabindex="0" href="/jobs/view/3437958949/?eBP=CwEAAAGGChz-oVFU8gZnJZjq7DUuguzNwDeGe-pjGELan0i9QPsVgRWqSme18L-3QkJXz1E61BoHXIH55qUr4_xjd8By6gtXapu18OVnHofOqToOsiVuhVoiRmznMRqtE9wEV6b3-qTVGCYZh88s0bxfLtHo5I7W9U6yEazEBQ9ynuxuVO5vZZwvxhCTqDMSS2_5ZOnFViKNnp73suxNQegZ3EQ_T-hQK9YIiukEkVgLrJvLSh-riFeVw7kG0vtM6vCxWy7BpUTaTQM3H9R8imXcanXm0wMTH8GcWQPmNWA29bRox2JmjqnD0J7MkYkZeunpxhXq8CNdP-gDLg1hu-tgQxThyBFQaS0qwSK3TMhrJWKjLDbXdq7zTcimdPvAtHU&amp;refId=pX6vmpcu2hT0LHiywr15VA%3D%3D&amp;trackingId=DIjzaqUVGhRM274F52Of%2Bg%3D%3D&amp;trk=flagship3_search_srp_jobs" id="ember259" class="disabled ember-view job-card-container__link job-card-list__title">
              Développeur fonctionnel (OIPA)
            </a>

</div>
      <div id="ember260" class="artdeco-entity-lockup__subtitle ember-view">
          <span class="job-card-container__primary-description ">
              Equisoft
          </span>

      </div>

      <div id="ember261" class="artdeco-entity-lockup__caption ember-view">
            <ul class="job-card-container__metadata-wrapper">
                <li class="job-card-container__metadata-item ">
                  <!---->Montréal, QC (Sur site)<!---->
                </li>
<!---->            </ul>
      </div>
<!---->    </div>
    <div class="job-card-container__action-container flex-shrink-zero display-flex
        ">
          <div class="job-card-list__dismiss">
      <button aria-label="Ignorer l’offre d’emploi Développeur fonctionnel (OIPA)" id="ember262" class="job-card-container__action artdeco-button artdeco-button--circle artdeco-button--muted artdeco-button--2 artdeco-button--tertiary ember-view" type="button">  <li-icon aria-hidden="true" type="visibility-off" class="artdeco-button__icon"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32" data-supported-dps="32x32" fill="currentColor" class="mercado-match" width="32" height="32" focusable="false">
  <path d="M16 11.5a4.64 4.64 0 00-1.95.43l6 6A4.64 4.64 0 0020.5 16a4.42 4.42 0 00-4.5-4.5z"></path>
  <path d="M16 9.5a6.52 6.52 0 015.54 9.92l3.05 3A15.47 15.47 0 0030 16a15 15 0 00-14-9 15.67 15.67 0 00-5.8 1.08l2.38 2.38A6.47 6.47 0 0116 9.5zM3 3.71L8.29 9A15.42 15.42 0 002 16a15 15 0 0014 9 15.45 15.45 0 006.79-1.51l5.5 5.51.71-.71L3.71 3zm8.05 8.05l1.43 1.42a4.49 4.49 0 00-1 2.82A4.42 4.42 0 0016 20.5a4.49 4.49 0 002.82-1l1.42 1.5a6.52 6.52 0 01-9.19-9.19z"></path>
</svg></li-icon>

<span class="artdeco-button__text">

</span></button>
  </div>

<!---->        <!---->

    </div>

</div>

<!---->        <div class="job-card-list__insight">

          <div class="display-flex align-items-center t-black--light t-12">
              <div class="mv1">
                <div class="ivm-image-view-model   ">
    <div class="ivm-view-attr__img-wrapper ivm-view-attr__img-wrapper--use-img-tag display-flex

    ">
    <li-icon type="clipboard-check" class="ivm-view-attr__icon--brand job-card-container__job-insight-image" size="large" role="img" aria-label="Vous avez un badge de compétence préféré"><svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" data-supported-dps="24x24" fill="currentColor" class="mercado-match" width="24" height="24" focusable="false">
  <path d="M14.73 10H17l-5.5 8L8 14.5l1.34-1.34L11.21 15zM20 3v16a3 3 0 01-3 3H7a3 3 0 01-3-3V3h5.69l.52-1A2 2 0 0112 1a2 2 0 011.76 1l.52 1zm-2 2h-2.6l.6 1.1V7H8v-.9L8.6 5H6v14a1 1 0 001 1h10a1 1 0 001-1z"></path>
</svg></li-icon>
</div>
  </div>
              </div>
            <div class="job-card-container__job-insight-text">
                Vous avez un badge de compétence préféré
            </div>
          </div>

</div>

    <ul class="job-card-list__footer-wrapper job-card-container__footer-wrapper flex-shrink-zero display-flex t-sans t-12 t-black--light t-normal t-roman">
            <li class="job-card-container__footer-item inline-flex align-items-center">
              <!---->Promu(e)<!---->
            </li>
                      <li class="job-card-container__footer-item inline-flex align-items-center">
              <strong><span class="tvm__text tvm__text--positive"><!---->5&nbsp;candidats<!----></span></strong>
            </li>
              </ul>
  <span class="visually-hidden" aria-live="polite">

  </span>
</div>

<div id="ember263" class="ember-view"><!----></div>
</div>

    </li>
winterhazel commented 1 year ago

Yeah, they changed the layout. I need to modify how the extension finds the promoted items (the line you pointed out).

I think I'll make it check if the innerText of each <li> is in a list that contains the equivalent of "Promu(e)" of every language, so that it works on both the old and the new layouts. I'll see if I can work on this tomorrow.

Thanks for reporting this issue!

winterhazel commented 1 year ago

Well, they just updated the site for me too and it stopped working, but it actually seems like an easier fix.

I sent a commit to the firefox-fix branch that fixed it for me. Could you clone it and follow the instructions here to see if it works on your LinkedIn too?

Edit: nevermind, it doesn't work. I'll fix it tomorrow.

winterhazel commented 1 year ago

I just published a new version that I think fixed it. Could you check if it's working on your device?

lecanardcolvert commented 1 year ago

It's working now. Thank you so much!