search

wintersleepAI / foundry-swnr

Stars Without Number: Revised for Foundry VTT
GNU Affero General Public License v3.0
31 stars 21 forks source link

Fixed an issue with actor id when dropping sheets onto a vehicle #30

Closed giuseppe-crea closed 1 year ago

giuseppe-crea commented 1 year ago

The id property of actor sheets is not available anymore. This fix uses the "uuid" element available in the data object and rebuilds the id string, restoring functionality to vehicle sheets.

wintersleepAI commented 1 year ago

Thanks! I haven't gotten to this one yet. Did you test this approach in v9? I am not ready to make the code only v10 yet. I want to get a 1.0 release that supports v9 and v10, then start a release that is v10 only.

giuseppe-crea commented 1 year ago

Sadly I haven't tested this on v9, I will do that once I have some free time. Depending on whether or not the uuid model was already there in the v9 api (the migration page isn't clear on this, it says the uuid system already exists in foundry as of versions before 10, but that it wasn't used by everything) this might work out of the box or require a version/null check.

wintersleepAI commented 1 year ago

Tried merging this in the latest v1.0 alpha release (tried to change it so it works with v9 or v10). Wasn't able to do a pull as the code has been on a branch for a while and needed to make the v9 part work. Thanks though,, this saved me time!!! Are you wanting to do more on the system?

giuseppe-crea commented 1 year ago

I could help if new issues crop up, but for the next month or two I'll be rather busy sadly, too busy to join development in an active role.

wintersleepAI commented 1 year ago

manually merged so the code supports v9 and v10. thanks for finding the solution!

wintersleepAI commented 1 year ago

also FYI i usually work on a dev branch until the final release is made