search

winterstein / sogive-app

The SoGive user app - See your impact
Other
2 stars 5 forks source link

Set 'name' not 'displayName' for dummy charity on startup #221

Closed anitawoodruff closed 3 years ago

anitawoodruff commented 3 years ago

'tbd' is supposed to be a dummy charity that can stand in for a real charity for testing

While the handful of real charities I checked all had 'name' set, at least one ('The END Fund') did not have displayName set

Therefore it makes sense to make the dummy charity have this 'name' property instead of displayName

(Also, if 'name' is not set then the DonationWizard crashes. What do you think, should DonationWizard handle this edge case? Or do we expect 'name' to always be set? It could fallback to charity id, but for payments I don't know if that would be a valid recipient..)

winterstein commented 3 years ago

'tbd' is supposed to be a dummy charity that can stand in for a real charity for testing

While the handful of real charities I checked all had 'name' set, at least one ('The END Fund') did not have displayName set

Therefore it makes sense to make the dummy charity have this 'name' property instead of displayName

(Also, if 'name' is not set then the DonationWizard crashes. What do you think, should DonationWizard handle this edge case? Or do we expect 'name' to always be set? It could fallback to charity id, but for payments I don't know if that would be a valid recipient..)