search

wirepair / gcd

Unofficial implementation of the Google Chrome Remote Debugger in Go
MIT License
186 stars 31 forks source link

protocol.json/browser_protocol.json uncertanties #21

Open wirepair opened 6 years ago

wirepair commented 6 years ago

Looks like once again the protocol files are being changed. The location changed, and will only be available in 'pdl' format. Currently, the json files are converted and pushed to: https://github.com/ChromeDevTools/devtools-protocol/tree/master/json. The problem is this is only the 'stable' channel. I don't see any other channels. So if someone wants to, say, use the dev channel, they'll need to figure out another method.

What This Means: I'm just going to switch gcdapigen to download the JSON files directly from the devtools-protocol repo and remove the ability of choosing a branch.

How someone could help: Write a PDL -> json or PDL -> go struct converter and we can re-enable the ability to download different branch/channels for devtools support.

Unfortunately, I do not really use this library personally at the moment so I don't have time to invest in doing it correctly (pdl converter).

If someone wants to step up, that'd be great.

kenshaw commented 6 years ago

Frustrating, no? Use cdproto-gen -- planning on rewriting it to use the .pdl files natively from the chromium source.

kenshaw commented 6 years ago

@wirepair just dropping a line that I got around to implementing a .pdl parser: https://github.com/chromedp/cdproto-gen/blob/master/types/pdl.go

wirepair commented 6 years ago

@kenshaw excellent! Thanks for letting me know.