search

wisdomikezogwo / quilt1m

[NeurIPS 2023 Oral] Quilt-1M: One Million Image-Text Pairs for Histopathology.
https://quilt1m.github.io/
MIT License
138 stars 8 forks source link

Missing Imports and Code Errors #5

Closed vinid closed 1 year ago

vinid commented 1 year ago

Hello!

Thanks for the great resource!

I have been trying to run the data reconstruction but I kind of stumbled upon a couple of different errors (some are missing imports - e.g., nn from torch - one was a parenthesis that was not closed). There are also a couple of missing requirements (e.g., scikit-image) in the requirements file.

Would you mind taking a look? I have solved some of these and I am happy to send a PR in case but maybe you have an updated version of the code that runs out of the box.

wisdomikezogwo commented 1 year ago

Hi,

Thanks for trying to reconstruct Quilt!

Went ahead and made the code changes and fixed the imports. Also, noticed scikit-image is already in the requirements file so not sure why it's an issue, it may be that the particular version is off and so was not installed, I went ahead and removed the version tag just in case as it should not affect anything.

Finally, please let me know if there are any more issues.

vinid commented 1 year ago

thank you so much for the prompt reply! Trying this now!

vinid commented 1 year ago

The instruction specifies that the CSVs should be put in ${BASE_DIR}/videos/....

However, I see the code is as follows: recon_df = pd.read_csv(os.path.join(BASE_DIR, 'quilt_recon.csv'))

I solved the error by moving both CSVs to BASE_DIR but might be worth updating this.

Is there anything specific I might be doing wrong? Thank you so much for your help!

Update: the error was on me