search

wise-foundation / lending-audit

5 stars 4 forks source link

[THR-01S] Inexistent Visibility Specifiers #139

Open vm06007 opened 1 year ago

vm06007 commented 1 year ago

THR-01S: Inexistent Visibility Specifiers

Type Severity Location
Code Style TransferHelper.sol:L9, L13

Description:

The linked variables have no visibility specifier explicitly set.

Example:

bytes4 constant transfer = IERC20

Recommendation:

We advise them to be set so to avoid potential compilation discrepancies in the future as the current behaviour is for the compiler to assign one automatically which may deviate between pragma versions.

vm06007 commented 1 year ago

Resolved in: https://github.com/wise-foundation/lending-audit/pull/134