wiserain / docker-flexget

Docker image for running Flexget
https://hub.docker.com/r/wiserain/flexget
68 stars 40 forks source link

FG_WEBUI_PASSWD doesn't work when 'Password is not strong enough' #12

Closed kujyp closed 4 years ago

kujyp commented 4 years ago

https://github.com/wiserain/docker-flexget/blob/2f9ed8b9b56a98060af7d4106a56bd5660199fa7/root/etc/cont-init.d/20-config#L38-L44

If 'Password is not strong enough', flexget web passwd command fails but it returns exitcode '0'(success).

$ flexget web passwd 1234; echo $?
There is a FlexGet process already running for this config, sending execution there.
Password '1234' is not strong enough. This is a top-10 common password. Suggestions: Add another word or two. Uncommon words are better.
0

So this shell conditional statement doesn't work. flexget -c /config/config.yml web passwd "${FG_WEBUI_PASSWD}" && <succeed> || <fail>

kujyp commented 4 years ago

$ flexget -c /config/config.yml web passwd webuipasswd | grep 'Updated password' >/dev/null && echo success || echo failure
> success

$ flexget -c /config/config.yml web passwd 1234 | grep 'Updated password' >/dev/null && echo success || echo failure
> failure
wiserain commented 4 years ago

Thanks for the fix!