search

wisespace-io / binance-rs

Rust Library for the Binance API
Other
671 stars 300 forks source link

spot depth events don't work. #109

Closed KalitaAlexey closed 3 years ago

KalitaAlexey commented 3 years ago

106d53f810e2d21bd9801cf373b5c8fd821292af (my commit) broke spot DepthOrderBookEvent because it doesn't have pu, instead they rely on U and u.

dorak88783 commented 3 years ago

I didn't review the last commit, but does this means there's not enough test coverage on these events?

KalitaAlexey commented 3 years ago

Given cargo test succeeds, I guess the crate don't have tests that ensure that DepthOrderBookEvent can be deserialized from json.