withastro / compiler

The Astro compiler. Written in Go. Distributed as WASM.
Other
503 stars 59 forks source link

Fix content treated as string after JSX comment inside expression #895

Closed MoustaphaDev closed 11 months ago

MoustaphaDev commented 1 year ago

Changes

Partial fix for #609

Fix the issues where HTML and JSX comments lead to subsequent content being incorrectly treated as plain text when they have parent expressions.

897 will fix the final issue mentioned in #609 which is kind of unrelated to JSX comments being used, but expressions in general

Testing

Added printer test for each case mentioned in the issue

Docs

N/A bug fix

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3f2d095b82d474325472371bdf56ec9761cf86c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @astrojs/compiler | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

MoustaphaDev commented 11 months ago

!preview err-jsx-comments-in-expr

github-actions[bot] commented 11 months ago
 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--err-jsx-comments-in-expr" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--err-jsx-comments-in-expr tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-err-jsx-comments-in-expr-20231218110825) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-err-jsx-comments-in-expr-20231218110825" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-err-jsx-comments-in-expr-20231218110825 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-err-jsx-comments-in-expr-20231218110825