Splash template on mobile unable to access social/theme/language menu

magicDGS commented 1 year ago

What version of `starlight` are you using?

0.11.1

What version of `astro` are you using?

3.2.3

What package manager are you using?

npm

What operating system are you using?

Windows

What browser are you using?

Firefox/Chrome

Describe the Bug

In the basic example directly, there is no way to change on mobile on a landing page (splash template) the theme, as th emenu is not there. The same happen with the social icons and languages in case that there is i18n, that are not present. Thus in mobile the experience of the landing page is poor and not sure if it is intentional.

I haven't mark checkbox to participate with a PR, but I am willing to do so if I have some guidance as I am not familiar with the codebase (nor too much with javascript yet, although I have experience on other programming languages and software development in general).

Link to Minimal Reproducible Example

https://stackblitz.com/github/withastro/starlight/tree/main/examples/basics

Participation

[ ] I am willing to submit a pull request for this issue.

delucis commented 1 year ago

Thanks for the issue @magicDGS!

What do people think a possible solution would be here?

Should landing pages always show the mobile menu?
If so, should they include full navigation (even though they don't on larger screens) or would the menu just include the links and language/theme selectors?

magicDGS commented 1 year ago

My 2 cents here (only for the second bullet point): I don't think that they should include the full-navigation even in the case that the menu is present. Maybe the idea then should go more on the direction of showing those components somewhere else instead, to enable the final user on mobile to access them. But as I said on a different discussion, I would not be too strong on my opinion as I am new into UI/UX.

MrAlex94 commented 1 year ago

If I may chip in:

Should landing pages always show the mobile menu?

That seems reasonable to me, at least from a feature parity standpoint. Having to go to the docs to change language then return back to the splash, seems a bit cumbersome, for example.

If so, should they include full navigation (even though they don't on larger screens) or would the menu just include the links and language/theme selectors?

What does this mean exactly? E.g. on mobile current the splash displays logo + search icon. And on desktop (larger screens?), you can see logo + search + social + theme + language.

For a more selfish reason, we currently use the <Header> component to also shove in our navigation links, since we have multiple docs on one site. So having the button show on splash makes our lives easier :-)

rgilsimoes commented 9 months ago

Please disregard my design abilities, but why not just include the icons on the header?

at-the-vr commented 9 months ago

Please disregard my design abilities, but why not just include the icons on the header?

valid point but when you start adding social links and larger titles this becomes difficult to handle even with flexbox

rgilsimoes commented 9 months ago

Perhaps Social Links aren't as important as the language switch dropdown. So, it all comes to settle on a compromise.

BuckyBuck135 commented 3 months ago

A bit late to the party, but I wholeheartedly support to have the splash templates show the mobile menu as well. It currently requires a fair bit of overriding to show the menu on splash pages. I wouldn't change the way it looks though: keep it the same as how it's rendered on doc pages.

VisualEhrmanntraut commented 1 month ago

Why not put them in the page's footer?

withastro / starlight