search

wix / react-native-notifications

React Native Notifications
MIT License
3.25k stars 764 forks source link

fix: remove deprecated config #882

Closed Naturalclar closed 1 year ago

Naturalclar commented 2 years ago

Fixes #881

Removed deprecated parameter from react-native.config.js, causing autolinking to fail from react-native/cli v8

iovoz commented 2 years ago

Thanks for solution

vitorbarros commented 2 years ago

Is there anyone to solve the CI issue and merge this PR? @iovoz @DanielEliraz

stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

anatooly commented 2 years ago

This fix for this warning?

warn Package react-native-notifications contains invalid configuration: "dependency.assets" is not allowed. Please verify it's properly linked using "react-native config" command and contact the package maintainers about this.
stale[bot] commented 2 years ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Naturalclar commented 2 years ago

not stale

gavrichards commented 1 year ago

Would be great to see this merged! 🙏

anisimov74 commented 1 year ago

Dear maintainers, please merge this PR, since the change is quite simple.

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

sakramentas commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Okay that's ridiculous now. @wix I know you guys don't care about maintaining this repo anymore, but if you also don't intend to at least review/merge new contributions (while keeping this stupid stale bot active), please do us a favor and terminate the repo (or at least put a message on README saying it's not being maintained anymore).

Thanks.

stale[bot] commented 1 year ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

angelica-snowit commented 1 year ago

NOT STALE

sanchitos commented 1 year ago

NOT STALE

fahad86 commented 1 year ago

@Naturalclar can you please add a tag to the PR [type: accepted/enhancement] so that it enforce-label check doesn't fail?

Naturalclar commented 1 year ago

@fahad86 hi there! Unfortunately I dont have access rights to set any label to the PR. Sorry about that