wixtoolset / issues

WiX Toolset Issues Tracker
http://wixtoolset.org/
130 stars 24 forks source link

Add ability to opt out of path validation custom actions in WixUI at build time #8718

Open barnson opened 2 months ago

barnson commented 2 months ago

User story

As a setup developer, I can opt out of the current custom action path validation that occurs in WixUI dialog sets.

Proposal

The current WixUIValidatePath custom action is wired in and opt-out is at runtime using properties. WixUIValidatePath is frequently overkill; the native CheckTargetPath control event is sufficient for most cases---or at least, we should make it possible for users to determine if it's sufficient and not pay the cost of the custom action DLL.

I suppose we should keep WixUIValidatePath by default.

Now that we need a compiler extension, we can more easily manage references.

Considerations

It's worth considering not including WixUIValidatePath by default. Dropping all the custom actions (including WixUIPrintEula) massively simplifies custom dialog sets. (Ironically, it also eliminates the need for a compiler extension...)