search

wj331 / pe

0 stars 0 forks source link

BUG regarding integration of UNDO, DELETE ADD #13

Open wj331 opened 10 months ago

wj331 commented 10 months ago

Steps to replicate this issue

  1. add r/1 d/2023-01-01 08:00 to 2023-01-02 12:00 n/John Doe p/98765432 e/johnd@gmail.com
  2. add r/256 d/2023-02-01 15:00 to 2023-02-02 23:59 n/Betsy Crowe p/99990000 e/betsycrowe@gmail.com
  3. delete 2
  4. add r/256 d/2023-02-01 15:00 to 2023-02-02 23:59 n/Betsy Crowe p/99990000 e/betsycrowe@gmail.com
  5. Undo

Does not return me an error but instead gives me successful undo message as seen below

image.png

There is no increase in bookings which should have been the case after undo-ing

nus-se-script commented 10 months ago

Team's Response

As stated in the UG, If the deleted item was manually added back, then undo was performed, the deleted booking will not be added as it already exists in CheckMate which compares two bookings using their room number and booking period.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Adjust to Severity.Medium:

Sorry, the steps I gave to replicate the bug was partially wrong as I was rushing for time (this was the last bug report for Phase 1), but this is a bug which I feel should be of Severity.HIGH

This is the following steps to replicate the bug:

  1. add r/1 d/2023-01-01 08:00 to 2023-01-02 12:00 n/John Doe p/98765432 e/johnd@gmail.com
  2. add r/256 d/2023-02-01 15:00 to 2023-02-02 23:59 n/Betsy Crowe p/99990000 e/betsycrowe@gmail.com
  3. delete 2
  4. add r/256 d/2023-02-01 15:00 to 2023-02-02 23:59 n/johnny p/84390123 e/johny@gmail.com
  5. Undo

The difference is in step4 where details of another booking was added which now, the new booking added was made under the name 'johnny', and the undo failed to restore the deleted Betsy Crowe's booking but still gave a success message

The main idea here is a new booking is created with different details but undo is still success which results in a CONFLICTING booking by people of 2 different names.

Please refer to the following video as seen:
video:https://raw.githubusercontent.com/wj331/pe/main/files/3b4832ae-d2c4-46a3-9d46-e3e5759a5cd3.mp4

Apologies for the wrong steps to duplicate as I was rushing for time (this was the last bug report for Phase 1) But as mentioned in the course website:

image.png

The developers should have took greater efforts to test with any different name/booking inputs with the add command on the 4th step and he will realise that the undo was not successful as the deletion of Betsy Crowe's booking was not successfully undone.

Furthermore, I did mention that Does not return me an error but instead gives me successful undo message as seen below which the developers should have they should have expected that undo should not have been successful instead of simply asking me to read what was mentioned in the UG again.

Hence, Severity should be adjusted to Severity.Medium as this is a serious bug that affects some users and causes problem for hotel employees whenever they accidentally delete, add and undo, as it can result in double booking of hotel rooms with the program not showing any warnings, this can hence lead to occasional inconvenience.

type remains as functionalityBug as the functionality undo does not work as expected, which is to bring back a VALID previously deleted booking