search

wjwwood / serial

Cross-platform, Serial Port library written in C++
http://wjwwood.github.com/serial/
MIT License
2.11k stars 1.03k forks source link

Port to ROS 2 #209

Open rotu opened 5 years ago

rotu commented 5 years ago

fixes #204

rotu commented 5 years ago

CI is failing because it's trying to run ament, not colcon. I recommend just turning off CI for this branch.

cottsay commented 5 years ago

Here is an alternative change that is less invasive and includes tests: https://github.com/cottsay/serial/commit/f6bd881babeae71f49485f445bfe75d848c450be. You should consider pulling some of the goodness from that change into your proposal.

I'd also like to propose that this package be introduced into ROS 2 as a pure CMake package instead of ament. It has no ROS dependencies, and is useful outside of ROS.

Change to a pure CMake package: https://github.com/cottsay/serial/commit/4d5be00015bb1aad1017a064408e884d4af388db

Note that the pure CMake package and the Ament package are consumed in slightly different ways, so if the package were to be released as pure CMake, any current consumers of the Ament fork would likely need to be updated.

JWhitleyWork commented 3 years ago

@rotu @cottsay Any progress on this?

tonybaltovski commented 1 year ago

Any chance this can get merged and a release can be done for Humble?

moriarty commented 1 year ago

tonybaltovski commented 22 minutes ago

Oh wow you ran into this today too :laughing:

@wjwwood we've been using a branch for ROS 2 located here: https://github.com/tylerjw/serial/tree/ros2

tonybaltovski commented 1 year ago

Yup! Thanks for that. We are looking into porting some drivers that depend on it:

Thus, a release would be needed to bloom them as packages.