search

wmde / Diff

䷂ Library for diffing, patching and representing differences between objects
BSD 3-Clause "New" or "Revised" License
200 stars 15 forks source link

Add support for php 8.1 #129

Closed marko-ilic closed 1 year ago

marko-ilic commented 2 years ago

In the scope of this PR, the support for PHP 8.1 is added.

reedy commented 2 years ago

Some minor code style issues too

FILE: /home/travis/build/wmde/Diff/src/DiffOp/Diff/Diff.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 396 | ERROR | [x] Tabs must be used to indent lines; spaces are not
     |       |     allowed
     |       |     (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
reedy commented 2 years ago

I think this is nearly ready to merge :)

reedy commented 2 years ago

LGTM, probably ready to squash and merge. Which I unfortunately do not have rights on this repo to do.

I've just created https://github.com/wmde/Diff/pull/130 to play around with testing PHP 8.1 etc in .travis.yml

jdforrester commented 1 year ago

Hello lovely people. This is now critical-path for running MediaWiki tests on PHP 8.1 (due to Wikibase's privileged position in the gate). Is there any chance this could be completed and released so we can move forward?

mariushoch commented 1 year ago

This still needs to be resolved: https://github.com/wmde/Diff/pull/129/files#r846253808 (and the same in DiffOpRemove).

Other than that, I think this is good to go.