RGB rendering not working correctly

wonder-sk / point-cloud-experiments

Just some prototyping for QGIS point clouds implementation

1 stars 0 forks source link

RGB rendering not working correctly #59

Closed wonder-sk closed 3 years ago

wonder-sk commented 3 years ago

At least not for this dataset: https://pointcloud.hcmgis.vn/app/point-cloud/detail/banteay-kdei-temple-angkor-cambodia-5f6addf14bd68

The colors are quite random :-)

Additionally, if the range for R,G,B values is not set correctly, the message log ends up being flooded with huge amount of warnings like this:

2020-12-16T16:15:20     WARNING    QColor::setRgb: RGB parameters out of range

nyalldawson commented 3 years ago

Likely what's happening here is that untwine isn't correctly handling unsigned short attributes and somewhere internally is treating these as signed attributes, so the values from that point cloud are overflowing. (For reference entwine handles this correctly)

wonder-sk commented 3 years ago

Hmm but loading root node (0-0-0-0.laz) from untwine and entwine in CloudCompare gives me correctly rendered RGB point cloud in both cases... so I suspect something is wrong in our code...

nyalldawson commented 3 years ago

https://github.com/qgis/QGIS/pull/40735