search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Streamline campaign setup: Sync the code changes with the feature branch of Streamline onboarding #2630

Closed asvinb closed 1 month ago

asvinb commented 2 months ago

Merge #2458 into #2459

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 68.42105% with 42 lines in your changes missing coverage. Please review.

Project coverage is 62.6%. Comparing base (9a612d3) to head (aa4329c). Report is 201 commits behind head on feature/2459-campaign-creation-flow.

Files with missing lines Patch % Lines
...src/components/paid-ads/asset-group/asset-group.js 0.0% 12 Missing :warning:
js/src/components/app-tooltip/index.js 50.0% 3 Missing and 1 partial :warning:
js/src/components/tree-select-control/index.js 78.6% 3 Missing :warning:
...ute-mapping/attribute-mapping-delete-rule-modal.js 0.0% 1 Missing and 1 partial :warning:
.../attribute-mapping/attribute-mapping-rule-modal.js 50.0% 1 Missing and 1 partial :warning:
.../free-listings/setup-free-listings/form-content.js 0.0% 1 Missing and 1 partial :warning:
...c/components/stepper/step-content-actions/index.js 33.3% 1 Missing and 1 partial :warning:
js/src/components/tree-select-control/control.js 0.0% 1 Missing and 1 partial :warning:
js/src/data/actions.js 50.0% 2 Missing :warning:
...roduct-feed/review-request/review-request-modal.js 50.0% 2 Missing :warning:
... and 9 more
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2459-campaign-creation-flow #2630 +/- ## ===================================================================== - Coverage 63.8% 62.6% -1.1% ===================================================================== Files 326 319 -7 Lines 5089 5063 -26 Branches 1231 1232 +1 ===================================================================== - Hits 3245 3171 -74 - Misses 1676 1718 +42 - Partials 168 174 +6 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `62.6% <68.4%> (-1.1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js/src/attribute-mapping/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fattribute-mapping%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2F0dHJpYnV0ZS1tYXBwaW5nL2luZGV4Lmpz) | `100.0% <ø> (ø)` | | | [...ion/phone-number-card/verification-code-control.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fcontact-information%2Fphone-number-card%2Fverification-code-control.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvY29udGFjdC1pbmZvcm1hdGlvbi9waG9uZS1udW1iZXItY2FyZC92ZXJpZmljYXRpb24tY29kZS1jb250cm9sLmpz) | `98.2% <100.0%> (-0.1%)` | :arrow_down: | | [...choose-audience-section/choose-audience-section.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Ffree-listings%2Fchoose-audience-section%2Fchoose-audience-section.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZnJlZS1saXN0aW5ncy9jaG9vc2UtYXVkaWVuY2Utc2VjdGlvbi9jaG9vc2UtYXVkaWVuY2Utc2VjdGlvbi5qcw==) | `33.3% <ø> (+8.3%)` | :arrow_up: | | [...listings/configure-product-listings/checkErrors.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Ffree-listings%2Fconfigure-product-listings%2FcheckErrors.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvZnJlZS1saXN0aW5ncy9jb25maWd1cmUtcHJvZHVjdC1saXN0aW5ncy9jaGVja0Vycm9ycy5qcw==) | `100.0% <100.0%> (ø)` | | | [js/src/components/main-tab-nav/main-tab-nav.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fmain-tab-nav%2Fmain-tab-nav.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvbWFpbi10YWItbmF2L21haW4tdGFiLW5hdi5qcw==) | `90.0% <100.0%> (ø)` | | | [js/src/components/paid-ads/ads-campaign.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduLmpz) | `0.0% <ø> (ø)` | | | [...components/paid-ads/asset-group/images-selector.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fasset-group%2Fimages-selector.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYXNzZXQtZ3JvdXAvaW1hZ2VzLXNlbGVjdG9yLmpz) | `100.0% <ø> (ø)` | | | [js/src/components/paid-ads/faqs-panel.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Ffaqs-panel.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvZmFxcy1wYW5lbC5qcw==) | `66.7% <100.0%> (ø)` | | | [...rc/components/stepper/step-content-footer/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fstepper%2Fstep-content-footer%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvc3RlcHBlci9zdGVwLWNvbnRlbnQtZm9vdGVyL2luZGV4Lmpz) | `50.0% <100.0%> (+16.7%)` | :arrow_up: | | [js/src/components/tree-select-control/tags.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Ftree-select-control%2Ftags.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvdHJlZS1zZWxlY3QtY29udHJvbC90YWdzLmpz) | `92.9% <100.0%> (ø)` | | | ... and [41 more](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2630/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)
joemcgill commented 1 month ago

This is just handling merge conflicts from feature/2458-streamline-onboarding to this branch and updating feature/2459-campaign-creation-flow so with the upstream changes.

The merge conflict seemed to be handled correctly, so I'm merging these upstream changes to this feature branch so we can better see the changes that will be merged in https://github.com/woocommerce/google-listings-and-ads/pull/2632.