search

woocommerce / google-listings-and-ads

Sync your store with Google to list products for free, run paid ads, and track performance straight from your store dashboard.
https://woo.com/products/google-listings-and-ads/
GNU General Public License v3.0
47 stars 21 forks source link

Feature: Improve post-onboarding #2635

Closed joemcgill closed 1 week ago

joemcgill commented 1 month ago

Changes proposed in this Pull Request:

Closes #2460.

This feature branch includes the following issues:

This feature branch incudes changes from the following pull requests:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 65.2%. Comparing base (42335a1) to head (37dacee). Report is 102 commits behind head on feature/2458-2459-2460-2509.

Files with missing lines Patch % Lines
...c/dashboard/summary-section/paid-features/index.js 16.7% 5 Missing :warning:
js/src/dashboard/summary-section/index.js 66.7% 2 Missing :warning:
...product-statistics/create-campaign-notice/index.js 77.8% 2 Missing :warning:
src/Notes/SetupCampaignTwoWeeks.php 0.0% 2 Missing :warning:
...src/components/paid-ads/asset-group/asset-group.js 0.0% 1 Missing :warning:
...rd/summary-section/paid-campaign-promotion-card.js 0.0% 1 Missing :warning:
...rd/summary-section/paid-features/free-ad-credit.js 50.0% 1 Missing :warning:
src/Notes/CompleteSetup.php 0.0% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635/graphs/tree.svg?width=650&height=150&src=pr&token=UROWUPF1LX&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) ```diff @@ Coverage Diff @@ ## feature/2458-2459-2460-2509 #2635 +/- ## =============================================================== + Coverage 65.2% 65.2% +0.1% Complexity 4587 4587 =============================================================== Files 804 806 +2 Lines 24269 24274 +5 Branches 1246 1242 -4 =============================================================== + Hits 15814 15835 +21 + Misses 8280 8267 -13 + Partials 175 172 -3 ``` | [Flag](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [js-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `62.5% <53.8%> (+0.4%)` | :arrow_up: | | [php-unit-tests](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | `65.9% <0.0%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | Coverage Δ | | |---|---|---| | [...rc/components/paid-ads/add-paid-campaign-button.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fadd-paid-campaign-button.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRkLXBhaWQtY2FtcGFpZ24tYnV0dG9uLmpz) | `73.3% <100.0%> (ø)` | | | [...c/components/paid-ads/ads-campaign/ads-campaign.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fads-campaign.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL2Fkcy1jYW1wYWlnbi5qcw==) | `0.0% <ø> (ø)` | | | [...paid-ads/ads-campaign/paid-ads-features-section.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fads-campaign%2Fpaid-ads-features-section.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYWRzLWNhbXBhaWduL3BhaWQtYWRzLWZlYXR1cmVzLXNlY3Rpb24uanM=) | `0.0% <ø> (ø)` | | | [...-ads/budget-section/budget-recommendation/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fcomponents%2Fpaid-ads%2Fbudget-section%2Fbudget-recommendation%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2NvbXBvbmVudHMvcGFpZC1hZHMvYnVkZ2V0LXNlY3Rpb24vYnVkZ2V0LXJlY29tbWVuZGF0aW9uL2luZGV4Lmpz) | `5.3% <ø> (ø)` | | | [...-program-button/edit-program-prompt-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fedit-program-button%2Fedit-program-prompt-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9lZGl0LXByb2dyYW0tYnV0dG9uL2VkaXQtcHJvZ3JhbS1wcm9tcHQtbW9kYWwvaW5kZXguanM=) | `10.0% <ø> (ø)` | | | [...e-card/program-toggle/pause-program-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fprogram-toggle%2Fpause-program-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9wcm9ncmFtLXRvZ2dsZS9wYXVzZS1wcm9ncmFtLW1vZGFsL2luZGV4Lmpz) | `14.3% <ø> (ø)` | | | [...emove-program-button/remove-program-modal/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fall-programs-table-card%2Fremove-program-button%2Fremove-program-modal%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9hbGwtcHJvZ3JhbXMtdGFibGUtY2FyZC9yZW1vdmUtcHJvZ3JhbS1idXR0b24vcmVtb3ZlLXByb2dyYW0tbW9kYWwvaW5kZXguanM=) | `7.1% <ø> (ø)` | | | [...dashboard/campaign-creation-success-guide/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fdashboard%2Fcampaign-creation-success-guide%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL2Rhc2hib2FyZC9jYW1wYWlnbi1jcmVhdGlvbi1zdWNjZXNzLWd1aWRlL2luZGV4Lmpz) | `71.4% <ø> (ø)` | | | [js/src/pages/create-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fcreate-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2NyZWF0ZS1wYWlkLWFkcy1jYW1wYWlnbi9pbmRleC5qcw==) | `10.0% <ø> (ø)` | | | [js/src/pages/edit-paid-ads-campaign/index.js](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree&filepath=js%2Fsrc%2Fpages%2Fedit-paid-ads-campaign%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce#diff-anMvc3JjL3BhZ2VzL2VkaXQtcGFpZC1hZHMtY2FtcGFpZ24vaW5kZXguanM=) | `8.6% <ø> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/woocommerce/google-listings-and-ads/pull/2635/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=woocommerce)

🚨 Try these New Features:

joemcgill commented 1 week ago

@eason9487 I've just opened #2683 to finish any final text tweaks that need to be made following from #2664. This should be merged prior to finalizing #2682.