woocommerce / storefront

Official theme for WooCommerce
https://wordpress.org/themes/storefront/
974 stars 470 forks source link

Serve Source Sans locally - avoid law suits #2077

Open koppor opened 1 year ago

koppor commented 1 year ago

Is your feature request related to a problem? Please describe.

In Germany, it is forbidden to fetch Fonts from Google. If one doesn't follow this rule, one has to play (at least) 300€ per case. See https://ll-ip.com/aktuelles/raag-kanzlei-dikigoros-nikolaos-kairis/ for details.

Describe the solution you'd like

Storefront should ship the font in its distribution.

Describe alternatives you've considered

There is a hint at https://wordpress.org/support/topic/css-font-display-how-to-add/ to create a child theme. It seems, however that 300+ lines of code need to be copied - only for replacing one font.

dinhtungdu commented 1 year ago

Hi @koppor,

Thanks for your report. I acknowledge the issue of Google Fonts and GDPR and I can confirm Storefront is loading Source Sans directly from Google Fonts as you described.

Storefront should ship the font in its distribution.

Thanks for your suggestion. Our team will need to discuss this before taking any action. Because Storefront is now in maintenance mode, the process can take a while.

In the meantime, you can use a plugin to make your site GDPR-compliant: https://wordpress.org/plugins/local-google-fonts/. Can you please test that plugin to see if it solves your issue?

koppor commented 1 year ago

Thank you for the quick response. The plugin works great, thank you for the hint!

Aljullu commented 1 year ago

Heads-up that in https://github.com/woocommerce/storefront/issues/845#issuecomment-386379581 there is a suggested snippet that might also work. There is also this filter that might be useful.