Closed rrennick closed 4 years ago
@rrennick thanks for working on it!
Typos in PHPDoc blocks
Great, thanks! Looks good.
order
synopsis fromwp wc generate order <id>
to actual implementationwp wc generate order <amount>
What I did here is confirmed that:
wp wc generate orders
generates 100 orders by defaultwp wc generate orders 30
generates 30 ordersBoth generated correct results.
implement order
default of 100 and change the option to optional
I am not sure I understand what command should I run here and what result is expected? Would you please clarify?
I am not sure I understand what command should I run here and what result is expected? Would you please clarify?
@juliaamosova The command help said the default was 100 but the implemented default was zero. You tested the default with
running wp wc generate orders generates 100 orders by default
@juliaamosova The command help said the default was 100 but the implemented default was zero. You tested the default with
running wp wc generate orders generates 100 orders by default
Perfect, thanks for clarifying @rrennick! This is good to go then. The code change looks good to me as well.
This PR fixes 3 minor issues with WP CLI command registrations
order
synopsis fromwp wc generate order <id>
to actual implementationwp wc generate order <amount>
order <amount>
default of100
and change the option to optional