woocommerce / wc-smooth-generator

Smooth product, customer and order generation for WooCommerce
315 stars 49 forks source link

fix WP CLI order synopsis, phpdoc typos #41

Closed rrennick closed 4 years ago

rrennick commented 4 years ago

This PR fixes 3 minor issues with WP CLI command registrations

juliaamosova commented 4 years ago

@rrennick thanks for working on it!

Typos in PHPDoc blocks

Great, thanks! Looks good.

order synopsis from wp wc generate order <id> to actual implementation wp wc generate order <amount>

What I did here is confirmed that:

Both generated correct results.

implement order default of 100 and change the option to optional

I am not sure I understand what command should I run here and what result is expected? Would you please clarify?

rrennick commented 4 years ago

I am not sure I understand what command should I run here and what result is expected? Would you please clarify?

@juliaamosova The command help said the default was 100 but the implemented default was zero. You tested the default with

running wp wc generate orders generates 100 orders by default

juliaamosova commented 4 years ago

@juliaamosova The command help said the default was 100 but the implemented default was zero. You tested the default with

running wp wc generate orders generates 100 orders by default

Perfect, thanks for clarifying @rrennick! This is good to go then. The code change looks good to me as well.