woocommerce / woocommerce-gateway-payfast

South African payment gateway supporting subscriptions, deposits & pre-orders
https://wordpress.org/plugins/woocommerce-payfast-gateway/
43 stars 15 forks source link

Use urlencode #224

Closed slash1andy closed 6 months ago

slash1andy commented 6 months ago

Use urlencode in place of get_site_url

All Submissions:


Changes proposed in this Pull Request:

Use urlencode instead of simply returning the site url

Steps to test the changes in this Pull Request:

Activate plugin and process a transaction

Changelog entry

Fix - Use rawurlencode around the call to get_site_url to ensure things are encoded properly.

ankitguptaindia commented 6 months ago

@slash1andy Could you please clarify which area of this plugin might be affected by this improvement? This will enable me to thoroughly test and verify the change manually. Thank you!

ankitguptaindia commented 6 months ago

QA/Test Report-

Testing Environment -

* WordPress: 6.5.3 * Theme: Twenty Twenty-Four Version: 1.1 * WooCommerce - Version 8.8.3 * PHP: 8.3 * Web Server: Nginx * Browser: Chrome - Version 124 * OS: macOS Sonoma 14.4.1 * Git Branch: patch-05-13-24

Test Results - The order was placed successfully after initiating an order while using Payfast as the payment method. All actions related to the order and Payfast payment were found as working.

Next Step- Ready for UAT.