Closed geriux closed 6 months ago
Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature.
No worries if you can't, let me know either way. Thanks! 🙇
Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature.
No worries if you can't, let me know either way. Thanks! 🙇
Hey @geriux! 👋 I'll be glad to. 👍
Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature. No worries if you can't, let me know either way. Thanks! 🙇
Hey @geriux! 👋 I'll be glad to. 👍
🎉 thank you!
👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!
👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!
Hey @twstokes Thank you for reaching out! Due to other priorities, I couldn't focus on addressing your feedback but I will go back to this so we can include this fix. 🙇
👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!
Hey @twstokes Thank you for reaching out! Due to other priorities, I couldn't focus on addressing your feedback but I will go back to this so we can include this fix. 🙇
Sounds good!
Hey there @twstokes 👋 I'm sorry this took so long to move forward but I've introduced new changes that should fix the issues you mentioned above 🚀
Related PRs:
This PR fixes several issues related to the Mark formatting.
MarkStringAttributeConverter
which will handle toggling the format as well as returning the expected HTML format to Gutenberg, by removing the extra spaces. This was causing issues like history changes or showing the active style indicator when it shouldn't.MarkFormatter
to set the expected CSS attributes as well as adding acolor
param.preprocessMarkForInsertion
that will handle cases like auto-corrected strings, it will check if the new auto-corrected words need to have the Mark representation along withadjustAttributesForMark
.toggleMark
by allowing passing acolor
param and to be able to change colors while editing a Mark formatting or resetting the existing format.To test
Check this PR description under the
Test
section. Where there are builds linked as well.