wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

Address `UnsafeImplicitIntentLaunch` lint error #21085

Open wzieba opened 2 months ago

wzieba commented 2 months ago

Expected behavior

UnsafeImplicitIntentLaunch lint error is not raised when running lint task.

Actual behavior

UnsafeImplicitIntentLaunch is reported 12 times.

Steps to reproduce the behavior

Remove UnsafeImplicitIntentLaunch from the lint baseline file and run lint task (after #21082 is merged).


From what I understood in my research, some Intent calls made for a system web browser are considered by lint to launch JetpackConnectionResultActivity, which only cares about wordpress://jetpack-connection?reason={error} type of links (not https). I'd appreciate a second check if this make sense. I'm also not sure what's the prefered solution - suppressing, or maybe there's something better like communicating to Intents that it should point to external components only?

dangermattic commented 2 months ago

Thanks for reporting! 👍