wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

Issue/17453-Multi line display of text in 'About me' #21310

Closed Agoni-0 closed 1 month ago

Agoni-0 commented 1 month ago

Fixes #


Description: This issue in related to issue/17453. This issue describes a problem that the "About me" text field is a short field, like "name" which means it's not possible to see the full text. image I found that this is caused by the incorrect settings of multiple line representation of the 'EditText'.

To Test:

Due to the ’My Profile‘ page not displaying during debugging, I modified the code and used a small demo to test it. This demo consists of relevant components from the source code. I have tested it on both real and virtual device. It seems that it works well. Screenshot_20241018_015915_com example myapplication


Regression Notes

  1. Potential unintended areas of impact

    • None. I have also tested single line display when the control parameter is 'false'. It's fine.
    • image

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • I make a small demo and test the code on both real and virtual device.
  3. What automated tests I added (or what prevented me from doing so)

    • None. ’My Profile‘ page not displaying during debugging.

PR Submission Checklist:


Testing Checklist (strike-out the not-applying and unnecessary ones):

nbradbury commented 1 month ago

@Agoni-0 Thanks so much for your contribution! I'll be reviewing this shortly.

nbradbury commented 1 month ago

@Agoni-0 Fix looks but one change is required: it seems that gradle.properties-example was accidentally deleted in this PR, and that's a critical file for contributors. Once that's restored I'll approve and merge.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud