wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.32k forks source link

feat: Authenticate private resource requests #21331

Open dcalhoun opened 1 month ago

dcalhoun commented 1 month ago

Related

Description

Authenticate resource requests originating from within the WebView so that requests to private sites succeed.

To Test:

See https://github.com/wordpress-mobile/GutenbergKit/pull/34.

Regression Notes

  1. Potential unintended areas of impact Gutenberg Mobile or Aztec editors fail.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested both editors.
  3. What automated tests I added (or what prevented me from doing so) None, feels unnecessary for this currently experimental editor feature.

PR Submission Checklist:

Testing Checklist (strike-out the not-applying and unnecessary ones):

dangermattic commented 1 month ago
1 Warning
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago

Project dependencies changes

The following changes in project dependencies were detected (configuration wordpressVanillaReleaseRuntimeClasspath):

list ``` Upgraded Dependencies org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596, (changed from trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33) ```
tree ```diff +--- project :libs:editor -| \--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 +| \--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596 -\--- org.wordpress.gutenbergkit:android:trunk-a58a46f3fbb892f311b562e3c122d7ef4ebbfe33 (*) +\--- org.wordpress.gutenbergkit:android:trunk-d6fbfc7bc28ae6db2cce09950f24bc3080374596 (*) ```
wpmobilebot commented 1 month ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21331-172e55e
Commit172e55eb2924e9f28f86fa415fbc3392c10df3a8
Direct Downloadwordpress-prototype-build-pr21331-172e55e.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 1 month ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21331-172e55e
Commit172e55eb2924e9f28f86fa415fbc3392c10df3a8
Direct Downloadjetpack-prototype-build-pr21331-172e55e.apk
Note: Google Login is not supported on these builds.
sonarcloud[bot] commented 4 weeks ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dcalhoun commented 4 weeks ago

👋🏻 @jkmassel. I updated this with the merged https://github.com/wordpress-mobile/GutenbergKit/pull/30 and the latest from trunk. I re-tested and it appears to be functioning as expected. Whenever you have time, we can look to review and merge this feature. Thanks!