wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.66k stars 1.11k forks source link

Login/Signup: No validation when I tap "text me a code" #16436

Open osullivanchris opened 3 years ago

osullivanchris commented 3 years ago

Expected behavior

When I tap 'Text me a code instead', I expect to either receive a text, or be told that my number is not registered.

Actual behavior

Steps to reproduce the behavior

Tested on iPhone 12 Pro, iOS 14.4.2, WPiOS 17.3

IMG_1092

startuptester commented 3 years ago

Hey @osullivanchris , thanks for reporting 😊. I get an sms when I try, so just to make sure we're on the same page, you were not using an a8c email, right? SMS is disabled for those.

osullivanchris commented 3 years ago

Ahh right! I was using an A8C email 🤦 !!

It might still be a good idea to throw an error in there so you don't get further reports like this. But obviously low priority...

thehenrybyrd commented 3 years ago

We ran into this in Android 17.7 testing, and I was able to reproduce on a non-a8c test account. https://github.com/wordpress-mobile/WordPress-Android/issues/14984

thehenrybyrd commented 3 years ago

After some more tinkering, I realized I was using an a8c account on Android, but not on iOS. I was not able to reproduce on Android with a non-a8c account, but can reproduce on iOS with that same non-a8c account.

chipsnyder commented 3 years ago

I am able to recreate this with a non A8C email. In my testing I found that the failure to receive a SMS message was tied to a 400 response from https://public-api.wordpress.com/oauth2/token

chipsnyder commented 3 years ago

There was a customer mention of this in 4185023-zen

dangermattic commented 2 months ago

Thanks for reporting! 👍