search

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.64k stars 1.1k forks source link

Reader: Missing space between 'By' and 'author' for some languages. #19086

Open tiagomar opened 2 years ago

tiagomar commented 2 years ago

For some languages there is no space between By and author when viewing a post, like pt-br, it, de, he, etc. This is not a comprehensive list, there might be other languages with the same problem.

Expected behavior

EN FR
image image

Actual behavior

PT-BR IT DE HE
image image image image

Steps to reproduce the behavior

  1. Open a post.
  2. Change the device language to any of the affected languages.
Tested on iPhone 13, iOS 15.5, WPiOS 20.3.0.0
dlind1 commented 8 months ago

👋 This is indeed caused by the lack of a space for the translations of By in GlotPress.

I have went ahead and reviewed the translations for Mag-16 languages and added the missing space for German, Hebrew, Indonesian and Italian, as well as suggested a translation for Brazilian Portuguese and Swedish which would have to be approved. There are also some Korean/Chinese translations which don't have a space, but would need a review from a native speaker, plus the Japanese is using the English text, which should be fixed as well.

A possible solution would be to remove the whitespace from the original/translations and always add it in the code, provided that it'd work ok with Chinese/Korean/Japanese scripts.